Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: APP-12 change projects shown per page to 12 #2331

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

blushi
Copy link
Member

@blushi blushi commented Mar 25, 2024

Description

https://regennetwork.atlassian.net/browse/APP-13?atlOrigin=eyJpIjoiNGU3NjkyMTZkMDBhNDYyOWJlNjk5YjY5ODIxYWQzYTkiLCJwIjoiaiJ9


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

How to test

https://deploy-preview-2331--regen-marketplace.netlify.app/projects/1

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

Copy link

netlify bot commented Mar 25, 2024

Deploy Preview for regen-website ready!

Name Link
🔨 Latest commit e28996e
🔍 Latest deploy log https://app.netlify.com/sites/regen-website/deploys/66016b4162452e0008bd6ef7
😎 Deploy Preview https://deploy-preview-2331--regen-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@blushi
Copy link
Member Author

blushi commented Mar 25, 2024

@erikalogie
Copy link
Collaborator

@blushi this looks good but have we implemented any of the tasks to speed up load time? Otherwise we should probably not merge this work until after that as this page was quite slow previously.

@blushi
Copy link
Member Author

blushi commented Mar 26, 2024

@blushi this looks good but have we implemented any of the tasks to speed up load time? Otherwise we should probably not merge this work until after that as this page was quite slow previously.

We did implement some small optimizations but given the amount of queries and the data processing that we need to make here, I believe only SSR will only fully seem satisfying in terms of performance, see my notes in regen-network/rnd-dev-team#1895 (comment). So not something we'll have in the next release.
Let's just keep this unmerged for now then.

@blushi blushi marked this pull request as draft July 11, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants