-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: APP-201 buy credits flow step 1 #2408
Conversation
✅ Deploy Preview for regen-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've went through half of the PR, will continue next week.
Could you add some documentation about the tests setup you added? In the root README
web-components/src/components/cards/OrderSummaryCard/OrderSummaryCard.tsx
Outdated
Show resolved
Hide resolved
web-components/src/components/DenomIconWithCurrency/DenomIconWithCurrency.tsx
Outdated
Show resolved
Hide resolved
web-components/src/components/form/BuyCreditsForm/BuyCreditsForm.tsx
Outdated
Show resolved
Hide resolved
@erikalogie see testing instructions |
web-components/src/components/form/BuyCreditsForm/BuyCreditsForm.tsx
Outdated
Show resolved
Hide resolved
web-components/src/components/form/BuyCreditsForm/BuyCreditsForm.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For crypto purchase, when selecting a currency, it should say "1000 credits available in ${selectedCurrency}" because the number of credits available won't be the same based on the selected currency since for each sell order, the seller specifies one "ask denom": https://www.figma.com/design/BTuUv6QXY4GbliZcXCe8RJ/Fiat-payments?node-id=67-55906&t=HKrNrjQMGmY10ZLM-0
web-components/src/components/form/BuyCreditsForm/BuyCreditsForm.tsx
Outdated
Show resolved
Hide resolved
web-components/src/components/form/BuyCreditsForm/BuyCreditsForm.tsx
Outdated
Show resolved
Hide resolved
504d17c
to
b184ab7
Compare
@blushi @erikalogie All requested updates have been implemented, but we are still getting the error in some components in Storybook, so still WIP. For details on this see #2408 (comment) |
web-marketplace/src/components/organisms/ChooseCreditsForm/ChooseCreditsForm.schema.tsx
Outdated
Show resolved
Hide resolved
web-marketplace/src/components/organisms/ChooseCreditsForm/ChooseCreditsForm.schema.tsx
Outdated
Show resolved
Hide resolved
@erikalogie the issue with Storybook has been fixed. See links to fixed stories in the description please. |
web-marketplace/src/components/molecules/CreditsAmount/CreditsAmount.stories.tsx
Outdated
Show resolved
Hide resolved
web-marketplace/src/components/organisms/ChooseCreditsForm/ChooseCreditsForm.types.tsx
Outdated
Show resolved
Hide resolved
web-marketplace/src/components/molecules/CreditsAmount/CreditsAmount.mock.tsx
Outdated
Show resolved
Hide resolved
web-marketplace/src/components/organisms/ChooseCreditsForm/ChooseCreditsForm.tsx
Outdated
Show resolved
Hide resolved
web-marketplace/src/components/organisms/ChooseCreditsForm/ChooseCreditsForm.tsx
Show resolved
Hide resolved
web-marketplace/src/components/organisms/ChooseCreditsForm/ChooseCreditsForm.tsx
Outdated
Show resolved
Hide resolved
web-marketplace/src/components/organisms/ChooseCreditsForm/ChooseCreditsForm.schema.tsx
Outdated
Show resolved
Hide resolved
web-components/src/components/cards/OrderSummaryCard/OrderSummaryCard.tsx
Outdated
Show resolved
Hide resolved
web-components/src/components/cards/OrderSummaryCard/OrderSummaryCard.tsx
Outdated
Show resolved
Hide resolved
Looks good! Some small feedback, this is my fault for not providing a mobile view of the crypto view:
This is the rollover state for the unselected tab: https://www.figma.com/design/BTuUv6QXY4GbliZcXCe8RJ/Fiat-payments?node-id=2874-106112&t=bidt1T6CnWSUAMI3-1 |
43d39ce
to
7a61b7c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Still a few nits.
Thanks for adding all the tests. it'd be nice to give a small presentation of that sometimes during the architecture call so we start using those more widely and decide what's the strategy for adding tests to existing components.
web-marketplace/src/components/organisms/ChooseCreditsForm/ChooseCreditsForm.tsx
Outdated
Show resolved
Hide resolved
web-components/src/components/cards/OrderSummaryCard/OrderSummaryCard.Content.tsx
Outdated
Show resolved
Hide resolved
web-marketplace/src/components/organisms/ChooseCreditsForm/ChooseCreditsForm.tsx
Outdated
Show resolved
Hide resolved
web-marketplace/src/components/organisms/ChooseCreditsForm/ChooseCreditsForm.CryptoOptions.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pre-approving, pending fixing the TS error in web-marketplace that cause CI to fail and @erikalogie's QA approval
69d5a28
to
5596739
Compare
@erikalogie could you have a final look at this? |
…ing-library/react'
…rom useFormContext
88997ab
to
81a9183
Compare
Description
https://regennetwork.atlassian.net/browse/APP-201
/web-auth
workspaceBuffer is not defined
error in Storybook, closes: Fix Buffer issue on some stories rnd-dev-team#1799Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
How to test
No wrapper component for the whole step 1 has been implemented for now (will be in a follow-up integration task)
Individual components to review:
https://deploy-preview-2408--regen-storybook.netlify.app/?path=/story/denomiconwithcurrency--icon-and-currency
https://deploy-preview-2408--regen-storybook.netlify.app/?path=/story/cards-ordersummarycard--default
https://deploy-preview-2408--regen-storybook.netlify.app/?path=/story/denomiconwithcurrency--with-tooltip
https://deploy-preview-2408--regen-storybook.netlify.app/?path=/story/supcurrencyandamount--default
Fixed stories
https://deploy-preview-2408--regen-storybook.netlify.app/?path=/story/marketplace-organisms-choosecreditsform--choose-credits
https://deploy-preview-2408--regen-storybook.netlify.app/?path=/story/marketplace-molecules-creditsamount--credits-amount-card
https://deploy-preview-2408--regen-storybook.netlify.app/?path=/story/marketplace-molecules-creditsamount--credits-amount-crypto
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...