Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: APP-316 decoding file URLs #2462

Merged
merged 1 commit into from
Sep 10, 2024
Merged

fix: APP-316 decoding file URLs #2462

merged 1 commit into from
Sep 10, 2024

Conversation

blushi
Copy link
Member

@blushi blushi commented Sep 5, 2024

Description

Since I've merged https://github.com/regen-network/regen-server/pull/483, there was an issue when uploading data post file and previewing them on the form because we were not using the decoded URL.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

How to test

Create a post and upload a file, if that's an image you should see the preview in the "edit file" form, then after submitting you should see the file preview in the list of files on the create post form.

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

@blushi blushi requested a review from r41ph September 5, 2024 14:21
Copy link

netlify bot commented Sep 5, 2024

Deploy Preview for regen-website ready!

Name Link
🔨 Latest commit d127ab2
🔍 Latest deploy log https://app.netlify.com/sites/regen-website/deploys/66df0dd80ebc770008134941
😎 Deploy Preview https://deploy-preview-2462--regen-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@blushi blushi changed the title fix: decoding file URLs fix: APP-316 decoding file URLs Sep 5, 2024
@blushi blushi enabled auto-merge (squash) September 9, 2024 15:01
@blushi blushi disabled auto-merge September 9, 2024 15:02
@blushi blushi merged commit 7f0f673 into dev Sep 10, 2024
14 checks passed
@blushi blushi deleted the fix-APP-316-file-url branch September 10, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants