Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: translate web-components from Document to forms #2464

Merged
merged 6 commits into from
Sep 10, 2024

Conversation

flagrede
Copy link
Collaborator

@flagrede flagrede commented Sep 6, 2024

Description

translate web-components from Document to forms


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

How to test

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

Copy link

netlify bot commented Sep 6, 2024

Deploy Preview for regen-website ready!

Name Link
🔨 Latest commit 62fa2b5
🔍 Latest deploy log https://app.netlify.com/sites/regen-website/deploys/66e05f3bd2c02200082162bf
😎 Deploy Preview https://deploy-preview-2464--regen-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@flagrede flagrede force-pushed the feat-translate-web-components-part2 branch from 91af43f to 9429d9a Compare September 9, 2024 13:40
@flagrede flagrede marked this pull request as ready for review September 9, 2024 13:50
Copy link
Member

@blushi blushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is coming from these changes but while testing the app, I saw some missing spaces on the credits send form:

image

Pre-approving

@@ -14,14 +14,16 @@ export interface CreditPrice {
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could just drop this file, which isn't used anymore

@flagrede flagrede force-pushed the feat-translate-web-components-part2 branch from b2955af to 6798d00 Compare September 10, 2024 14:04
@flagrede
Copy link
Collaborator Author

@blushi I fixed the spacing issue.

@flagrede flagrede force-pushed the feat-translate-web-components-part2 branch from 0a22fa1 to 62fa2b5 Compare September 10, 2024 15:01
@flagrede flagrede merged commit 4570801 into dev Sep 10, 2024
14 checks passed
@flagrede flagrede deleted the feat-translate-web-components-part2 branch September 10, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants