feat: translate web-components from header to inputs #2468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for regen-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
flagrede
force-pushed
the
feat-translate-web-components-part3
branch
from
5115cd6
to
20a4c7a
Compare
flagrede
changed the title
wgardiner
reviewed
Sep 14, 2024
web-components/src/components/inputs/new/AmountField/AmountField.AuxiliaryLabel.tsx
Outdated
Show resolved
Hide resolved
web-components/src/components/inputs/new/FileDrop/FileDrop.UploadingModal.tsx
Outdated
Show resolved
Hide resolved
web-marketplace/src/components/organisms/MediaForm/MediaFormPhotos.tsx
Outdated
Show resolved
Hide resolved
web-marketplace/src/components/organisms/MediaForm/MediaFormStory.tsx
Outdated
Show resolved
Hide resolved
| @@ -70,6 +74,8 @@ const EmailSubmitSection = ({ altContent, sharedNewsletterData }: Props) => { | |||
| </Body> | |||
| </> | |||
| } | |||
| requiredMessage={REQUIRED_MESSAGE} | |||
There was a problem hiding this comment.
needs translation with _(...)?
flagrede
force-pushed
the
feat-translate-web-components-part3
branch
from
c720077
to
4fcfcbb
Compare
flagrede
force-pushed
the
feat-translate-web-components-part3
branch
from
4fcfcbb
to
5f4a4f8
Compare
wgardiner
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
translate web-components from header to inputs
Note for reviewers:
This commit is important as it extracts all the validation logic of forms that was in
web-components.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
How to test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...