feat: APP-163 custodial wallet design implementation #2470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for regen-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@erikalogie see testing instructions |
|
LGTM! |
blushi
reviewed
Sep 12, 2024
web-storybook/.storybook/preview.jsx
Outdated
Comment on lines
41
to
42
| <QueryClientProvider client={reactQueryClient}> | ||
| <AuthApolloProvider apolloClientFactory={apolloClientFactory}> |
There was a problem hiding this comment.
not sure if we should have storybook depend on those providers, which are really marketplace related
Instead if we want to keep the UserAccountSettings story, we should probably refactor it to not use those providers directly but rather provide what we need as props (from useEmailConfirmationData)
There was a problem hiding this comment.
@blushi updated as per our conversation, please have a look
r41ph
force-pushed
the
feat-APP-163-custodial-wallet-design-implentation
branch
from
0e659ec
to
29adbad
Compare
added 15 commits
September 16, 2024 15:02
r41ph
force-pushed
the
feat-APP-163-custodial-wallet-design-implentation
branch
from
da1b6e2
to
74373e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://regennetwork.atlassian.net/browse/APP-163
This PR also fixes an error with missing providers in the related stories in Storybook: https://regen-storybook.netlify.app/?path=/story/registry-organisms-useraccountsettings--default
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
How to test
Note: theLearn more»link needs to be updated with the correct URLReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...