Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: buy credits step2 #2480

Open
wants to merge 10 commits into
base: feat-APP-204-buy-credits
Choose a base branch
from

Conversation

blushi
Copy link
Member

@blushi blushi commented Sep 23, 2024

Description

  • Step 2 (payment/customer info) and if entering new credit card, getting current account payment methods and stripe confirmation token id as described in https://whimsical.com/stripe-flow-T4gUusQXghnWjobKbAd3Ex
  • Getting initial values from local storage on both ChooseCreditsForm and PaymentsInfoForm which involved a bit of refactoring

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

How to test

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

@blushi blushi requested a review from r41ph September 23, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant