style: APP-432 certificate footer update #2523
Conversation
✅ Deploy Preview for regen-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@erikalogie see testing instructions On top of the issues mentioned in the JIRA ticket, I noticed alignment issues when testing the responsiveness of the share section (see video) and have made some updates to improve that too. Could you have a look please? Screen.Recording.2024-10-30.at.14.03.24.mov |
|
This looks so much better! Thanks @r41ph! |
| sx={{ | ||
| [theme.breakpoints.up('md')]: { | ||
| gap: theme.spacing(4), | ||
| }, | ||
| }} |
There was a problem hiding this comment.
It was more convenient to do it this way because some Tailwind classes don't work with preflight disabled. However, I have now implemented those classes - see update in the tailwind.css file.
There was a problem hiding this comment.
I see
FYI spacing prop can also take responsive values, eg spacing={{ xs: 1, sm: 2, md: 3 }} but I guess it's probably best to work with tailwind anyway
r41ph
force-pushed
the
fix-APP-432-style-issues
branch
from
b82891c to
a327ae7
Compare
| @@ -75,26 +76,28 @@ function CertificatePage(): JSX.Element { | |||
| {certificateData && ( | |||
| <Grid | |||
| container | |||
| className={classes.share} | |||
| alignItems="flex-end" | |||
| sx={{ displayPrint: 'none' }} | |||
There was a problem hiding this comment.
just noticing this got removed, I'll add it back before merging
✅ Deploy Preview for terrasos ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
blushi
force-pushed
the
fix-APP-432-style-issues
branch
from
8021be4 to
53890b5
Compare
Description
https://regennetwork.atlassian.net/browse/APP-432
Author Checklist
I have...
How to test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...