APP 327 integrate Tebu factors #2525
Conversation
✅ Deploy Preview for regen-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
wgardiner
force-pushed
the
feat-APP-327-integrate-tebu-factors
branch
from
8c8e629
to
766bfdb
Compare
There was a problem hiding this comment.
Looks very good. Just one nit: looking at the design the cards should be centered on mobile and take available width: https://www.figma.com/design/brkxGV5qNOkZUp0YQl1cxO/Terrasos-Phase-1?node-id=1185-167335&node-type=instance&m=dev
figma:
web-marketplace/src/components/organisms/ProjectTopSection/ProjectTopSection.tsx
Outdated
Show resolved
Hide resolved
| @@ -60,8 +60,30 @@ export interface ProjectPageMetadataLD { | |||
| 'regen:projectQuote'?: ProjectQuote; | |||
| 'regen:boundaries'?: string; | |||
| 'regen:landManagementActions'?: NameImageDescription[]; | |||
|
|
|||
| // Terrasos-specific fields | |||
There was a problem hiding this comment.
I would assume these to be on chain if the project is on chain rather than in the project page metadata
There was a problem hiding this comment.
I forget our motivation, but I know we decided to put all the data into project page metadata, rather than putting data into anchored metadata. @S4mmyb was this just to let us release sooner?
There was a problem hiding this comment.
see suggestion: 111a15b
so should I wait for this PR to be merged then and use it instead?
There was a problem hiding this comment.
I wanted to keep things consistent with how we’ve organized things so far: if the project is on-chain, store data that isn't purely for display purposes on-chain and that might be class specific; if the project is off-chain, simply use the off-chain project metadata.
We only have one on chain terrasos project for now so this shouldn't be too much of an effort to put the data there, although it should work if in the interest of time, we keep it off chain for now... and put it on chain later.
There was a problem hiding this comment.
see suggestion: 111a15b
so should I wait for this PR to be merged then and use it instead?
this is now merged into dev
wgardiner
force-pushed
the
feat-APP-327-integrate-tebu-factors
branch
2 times, most recently
from
0fa15bb
to
6cb0539
Compare
wgardiner
force-pushed
the
feat-APP-327-integrate-tebu-factors
branch
from
6cb0539
to
d742e3d
Compare
wgardiner
force-pushed
the
feat-APP-327-integrate-tebu-factors
branch
from
d742e3d
to
00d6b67
Compare
Description
Closes: APP-327
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
How to test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...