Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: APP-434 include offchain projects to more projects section for terrasos #2526

Merged
merged 10 commits into from
Nov 6, 2024

Conversation

blushi
Copy link
Member

@blushi blushi commented Oct 31, 2024

Description

https://regennetwork.atlassian.net/browse/APP-434


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

How to test

From any project page, eg https://deploy-preview-2526--regen-marketplace.netlify.app/project/ee345f38-918b-11ef-8f65-022e215a294f, check out "More Projects" section at the bottom, it should show 3 random projects from https://deploy-preview-2526--regen-marketplace.netlify.app/projects/1 (on staging these are not necessarily all real terrasos projects)

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

Copy link

netlify bot commented Oct 31, 2024

Deploy Preview for regen-website ready!

Name Link
🔨 Latest commit d4184e1
🔍 Latest deploy log https://app.netlify.com/sites/regen-website/deploys/672b144c619cba00089bbd5d
😎 Deploy Preview https://deploy-preview-2526--regen-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@blushi
Copy link
Member Author

blushi commented Oct 31, 2024

@erikalogie @S4mmyb see testing instructions

@erikalogie
Copy link
Collaborator

Looks good! Do we need a separate task to make the project cards here match the ones on the /projects page once the credits available have been added? Or will those changes automatically be reflected in the more projects section?

@blushi
Copy link
Member Author

blushi commented Oct 31, 2024

Looks good! Do we need a separate task to make the project cards here match the ones on the /projects page once the credits available have been added? Or will those changes automatically be reflected in the more projects section?

There might be small adjustments to make but either I'll do it if #2520 gets merged first or @flagrede can do it if this PR gets merged first.

Copy link
Contributor

@wgardiner wgardiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Collaborator

@flagrede flagrede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@blushi I just merged #2520 , for the cards to behave the same as in /projects page you just need to add the creditsChildren prop (see example here: https://github.com/regen-network/regen-web/blob/dev/web-marketplace/src/pages/Projects/AllProjects/AllProjects.tsx#L283-L292).

@blushi
Copy link
Member Author

blushi commented Nov 5, 2024

Looks good! Do we need a separate task to make the project cards here match the ones on the /projects page once the credits available have been added? Or will those changes automatically be reflected in the more projects section?

I've addressed this here, please have another look @erikalogie

@erikalogie
Copy link
Collaborator

LGTM

@blushi blushi merged commit a2e84ae into dev Nov 6, 2024
14 checks passed
@blushi blushi deleted the fix-APP-434-more-projects branch November 6, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants