-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: APP-434 include offchain projects to more projects section for terrasos #2526
Conversation
✅ Deploy Preview for regen-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
699ca79
to
cc5386f
Compare
@erikalogie @S4mmyb see testing instructions |
Looks good! Do we need a separate task to make the project cards here match the ones on the /projects page once the credits available have been added? Or will those changes automatically be reflected in the more projects section? |
There might be small adjustments to make but either I'll do it if #2520 gets merged first or @flagrede can do it if this PR gets merged first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@blushi I just merged #2520 , for the cards to behave the same as in /projects
page you just need to add the creditsChildren
prop (see example here: https://github.com/regen-network/regen-web/blob/dev/web-marketplace/src/pages/Projects/AllProjects/AllProjects.tsx#L283-L292).
cc5386f
to
e1a53a1
Compare
I've addressed this here, please have another look @erikalogie |
LGTM |
5d4e468
to
d4184e1
Compare
Description
https://regennetwork.atlassian.net/browse/APP-434
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
How to test
From any project page, eg https://deploy-preview-2526--regen-marketplace.netlify.app/project/ee345f38-918b-11ef-8f65-022e215a294f, check out "More Projects" section at the bottom, it should show 3 random projects from https://deploy-preview-2526--regen-marketplace.netlify.app/projects/1 (on staging these are not necessarily all real terrasos projects)
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...