Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APP-323 Integrate project filters #2539

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

wgardiner
Copy link
Contributor

@wgardiner wgardiner commented Nov 11, 2024

Description

Closes: APP-323


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

How to test

  1. Navigate to all projects list page, review filters behavior on mobile and desktop

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

Copy link

netlify bot commented Nov 11, 2024

Deploy Preview for regen-website ready!

Name Link
🔨 Latest commit 18c48c0
🔍 Latest deploy log https://app.netlify.com/sites/regen-website/deploys/673491729082980008db4976
😎 Deploy Preview https://deploy-preview-2539--regen-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@wgardiner wgardiner force-pushed the feat-APP-323-project-filters-integration branch from 5bd7e8c to e980e74 Compare November 11, 2024 12:35
@wgardiner wgardiner changed the title integrate project filters APP-323 Integrate project filters Nov 11, 2024
Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for terrasos ready!

Name Link
🔨 Latest commit 18c48c0
🔍 Latest deploy log https://app.netlify.com/sites/terrasos/deploys/67349172f64a1b000841ab40
😎 Deploy Preview https://deploy-preview-2539--terrasos.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@wgardiner wgardiner force-pushed the feat-APP-323-project-filters-integration branch from c97bbd7 to e30e48b Compare November 13, 2024 10:43
@wgardiner wgardiner force-pushed the feat-APP-323-project-filters-integration branch from 95d0b36 to 9a06190 Compare November 13, 2024 10:51
@wgardiner wgardiner marked this pull request as ready for review November 13, 2024 10:51
@wgardiner wgardiner force-pushed the feat-APP-323-project-filters-integration branch from 9a06190 to 18c48c0 Compare November 13, 2024 11:45
@blushi
Copy link
Member

blushi commented Nov 13, 2024

could you run i18n:extract again?
this makes the new strings look like this

image

Copy link
Member

@blushi blushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I don't think we should be able to have both the left side bar and the mobile filter modal open on desktop and the filter sidebar is still there on mobile
image
  • If I use this branch with regen client (not terrasos), I get a mix of both existing regen and terrasos filters:
image
  • Also nothing happens if I click on the region or ecosystem filter items.

I still see several TODOs and console.log's, let me know if I can help to finish that up asap.

@S4mmyb
Copy link
Member

S4mmyb commented Nov 13, 2024

Hey @wgardiner et all , some things I noticed:

  • Noticing this is missing the button outline when you click a filter button. Right now all that happens is the color changes on the region from yellow to gray, but there's no outline on the button as well which makes it confusing / hard to know what is selected and what's not selected.
  • Like @blushi said, we shouldn't have both the sidebar filter and the modal in desktop. The designs originally showed that we only had the sidebar. That said, I'm noticing when I try and do split screen and the sidebar disapears it's nice to have the top modal. So, I think the desktop behavior should be that the mobile filter modal doesn't show up until the window size is too narrow to show the sidebar filter, at which point the sidebar filter is removed and the mobile filter modal appears. Thoughts @erikalogie @blushi ?
  • On mobile when I select a filter, I can't unselect it.
  • The text "add filters" and "edit filters" are longer in spanish ("Agregar filtros" and "Editar filtros"). What's the feature behavior for that when the window is smaller. Will we do two lines to display that? @wgardiner if you could add in some real text values on the deploy preview to test these that would be great. In general it's confusing to have deploy previews without the real text.
  • When we just select the "compliance" filter, how do we display projects which are tagged as both compliance and voluntary? Right now when it filters, we show the tebu logo instead of the ha logo. Is that what we want to happen? Or when they select only compliance, do we show the ha logo with the size? cc @erikalogie
  • Right now the button to view more filters cuts off in the middle of one of the filters. In the designs we show that it should show x amount of filter rows then the see more filters button (see photo below)
  • If I unselect both the voluntary and compliance filters, I am still able to see a project. Is this what we expect to happen? Shouldn't I not be able to see any of the projects? cc @erikalogie

image

@S4mmyb
Copy link
Member

S4mmyb commented Nov 13, 2024

Re-finishing this up. @wgardiner seems like there's still a bunch to do here so if @blushi can take on contributing to tie this up just let us know as we have a day left on the deliverable. We can also have @r41ph review

@blushi
Copy link
Member

blushi commented Nov 13, 2024

  • When we just select the "compliance" filter, how do we display projects which are tagged as both compliance and voluntary? Right now when it filters, we show the tebu logo instead of the ha logo. Is that what we want to happen? Or when they select only compliance, do we show the ha logo with the size? cc @erikalogie

@S4mmyb per this dev note on figma: https://www.figma.com/design/brkxGV5qNOkZUp0YQl1cxO/Terrasos-Phase-1?node-id=1111-319415&node-type=instance&t=8N51My8XTlyuHu3w-0 if a project is both compliance and voluntary, then we show the tebu tag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants