Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: APP-461 remove filters for Terrasos and change pagination to 9 #2542

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

flagrede
Copy link
Collaborator

Description

Closes: APP-461

Remove filters for Terrasos and change pagination to 9 projects per page.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

How to test

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

@flagrede flagrede requested a review from blushi November 12, 2024 09:26
Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for regen-website ready!

Name Link
🔨 Latest commit 2c9545d
🔍 Latest deploy log https://app.netlify.com/sites/regen-website/deploys/67361199a84f60000849c1e0
😎 Deploy Preview https://deploy-preview-2542--regen-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@blushi blushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, pending @erikalogie to test this once you set up VITE_MARKETPLACE_CLIENT=terrasos for this branch @flagrede

@flagrede
Copy link
Collaborator Author

@erikalogie You can check that the filters have been removed for Terrasos here: https://deploy-preview-2542--regen-marketplace.netlify.app/projects/1

Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for terrasos ready!

Name Link
🔨 Latest commit 2c9545d
🔍 Latest deploy log https://app.netlify.com/sites/terrasos/deploys/67361199b660160008b0a969
😎 Deploy Preview https://deploy-preview-2542--terrasos.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@erikalogie
Copy link
Collaborator

LGTM!

@erikalogie
Copy link
Collaborator

I just noticed that this spacing looks like not enough now:
Monosnap Terrasos – Inversiones para la Conservación de la Biodiversidad 2024-11-14 08-13-48

@blushi blushi force-pushed the feat-APP-461-remove-sort-filter-terrasos branch from 7d35325 to 11bcb01 Compare November 14, 2024 14:57
@blushi
Copy link
Member

blushi commented Nov 14, 2024

I just noticed that this spacing looks like not enough now: Monosnap Terrasos – Inversiones para la Conservación de la Biodiversidad 2024-11-14 08-13-48

I'll take care of that in the filters PR since we're adding the "add filters" button in between so it could interfer.

@blushi blushi force-pushed the feat-APP-461-remove-sort-filter-terrasos branch from 11bcb01 to 2c9545d Compare November 14, 2024 15:04
@blushi blushi merged commit acdb18b into dev Nov 14, 2024
18 checks passed
@blushi blushi deleted the feat-APP-461-remove-sort-filter-terrasos branch November 14, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants