fix: terrasos additional info #2543
Merged
+493
−480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for regen-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for terrasos ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
blushi
commented
Nov 13, 2024
web-marketplace/src/components/molecules/ProjectPageMetadata/ProjectPageMetadata.tsx
Outdated
Show resolved
Hide resolved
|
@erikalogie @S4mmyb you can test this on https://deploy-preview-2543--regen-marketplace.netlify.app/project/test-terrasos-project, switching to spanish |
|
LGTM |
|
Looks great! |
blushi
force-pushed
the
fix-terrasos-additional-info
branch
from
ecee0dc
to
20f35b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Putting the terrasos metadata fields as part of the "known fields" so the corresponding label gets translated on the project additional info tab.
A longer term solution for translating "unknown fields" labels on the go will be addressed as part of a follow-up issue: https://regennetwork.atlassian.net/browse/APP-471
Also fixes "read more" translation
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
How to test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...