Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: APP-409 set retiring to true when payment is card #2545

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

r41ph
Copy link
Contributor

@r41ph r41ph commented Nov 13, 2024

Description

https://regennetwork.atlassian.net/browse/APP-409

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

How to test

  1. https://deploy-preview-2545--regen-marketplace.netlify.app/project/mai-ndombe-4/buy
  2. Select crypto and then Buy tradable ecocredits
  3. Swap back to card and back again to crypto - verify that the Crypto purchase options is set to Retire credits now

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for regen-website ready!

Name Link
🔨 Latest commit f111271
🔍 Latest deploy log https://app.netlify.com/sites/regen-website/deploys/674437f5d8c30000086a7577
😎 Deploy Preview https://deploy-preview-2545--regen-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for terrasos ready!

Name Link
🔨 Latest commit f111271
🔍 Latest deploy log https://app.netlify.com/sites/terrasos/deploys/674437f567061700089a0c2f
😎 Deploy Preview https://deploy-preview-2545--terrasos.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@r41ph r41ph requested a review from blushi November 13, 2024 16:02
@r41ph
Copy link
Contributor Author

r41ph commented Nov 13, 2024

@erikalogie see testing instructions

1 similar comment
@r41ph
Copy link
Contributor Author

r41ph commented Nov 13, 2024

@erikalogie see testing instructions

@erikalogie
Copy link
Collaborator

@r41ph could you add some credits to buy with credit card, I forget how to do that

@r41ph
Copy link
Contributor Author

r41ph commented Nov 14, 2024

@r41ph r41ph force-pushed the fix-APP-409-set-retiring-to-true-for-card branch from 0a9e1d1 to 9902ee7 Compare November 14, 2024 15:30
@erikalogie
Copy link
Collaborator

Yeah on this one I can't buy any credit card credits, that tab is greyed out

@r41ph
Copy link
Contributor Author

r41ph commented Nov 14, 2024

Are you using the testing user? if so try logging out and see if you can see the fiat credits

@blushi
Copy link
Member

blushi commented Nov 18, 2024

tACK

@erikalogie
Copy link
Collaborator

LGTM

@blushi blushi force-pushed the fix-APP-409-set-retiring-to-true-for-card branch from 9902ee7 to f111271 Compare November 25, 2024 08:40
@blushi blushi enabled auto-merge (squash) November 25, 2024 08:41
@blushi blushi merged commit 3c44ecd into dev Nov 25, 2024
12 of 14 checks passed
@blushi blushi deleted the fix-APP-409-set-retiring-to-true-for-card branch November 25, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants