Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: APP-481 keep origin language for external links #2549

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

flagrede
Copy link
Collaborator

Description

Closes: APP-481

Keep origin language for external links.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

How to test

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

Copy link

netlify bot commented Nov 19, 2024

Deploy Preview for regen-website ready!

Name Link
🔨 Latest commit 377c974
🔍 Latest deploy log https://app.netlify.com/sites/regen-website/deploys/673c953fa4cb5a00082c38c0
😎 Deploy Preview https://deploy-preview-2549--regen-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 19, 2024

Deploy Preview for terrasos ready!

Name Link
🔨 Latest commit 377c974
🔍 Latest deploy log https://app.netlify.com/sites/terrasos/deploys/673c953ffabfba00080bd7ee
😎 Deploy Preview https://deploy-preview-2549--terrasos.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@flagrede flagrede force-pushed the fix-APP-481-consistent-language branch from 1e9bd76 to 377c974 Compare November 19, 2024 13:40
@flagrede flagrede requested review from blushi and wgardiner November 19, 2024 13:51
@flagrede
Copy link
Collaborator Author

@erikalogie You can check that the links keep the language from our app here: https://deploy-preview-2549--terrasos.netlify.app/projects/1

@erikalogie
Copy link
Collaborator

LGTM

@flagrede flagrede merged commit fce4585 into dev Nov 19, 2024
14 of 18 checks passed
@flagrede flagrede deleted the fix-APP-481-consistent-language branch November 19, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants