Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: APP-482 hide filters with no projects at all #2550

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

blushi
Copy link
Member

@blushi blushi commented Nov 20, 2024

Description

https://regennetwork.atlassian.net/browse/APP-482


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

How to test

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for regen-website ready!

Name Link
🔨 Latest commit 9bb47db
🔍 Latest deploy log https://app.netlify.com/sites/regen-website/deploys/673dbe441332eb000815a887
😎 Deploy Preview https://deploy-preview-2550--regen-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for terrasos ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/terrasos/deploys/673dc35400c64261dc219369
😎 Deploy Preview https://deploy-preview-2550--terrasos.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@blushi blushi requested review from flagrede and wgardiner November 20, 2024 10:45
@blushi
Copy link
Member Author

blushi commented Nov 20, 2024

@S4mmyb
Copy link
Member

S4mmyb commented Nov 20, 2024

This looks great @blushi ! Thanks. Do we want to keep track of the to-do to pull ecosystemTag and regionTag info from anchored data for when that day comes?

@blushi
Copy link
Member Author

blushi commented Nov 20, 2024

This looks great @blushi ! Thanks. Do we want to keep track of the to-do to pull ecosystemTag and regionTag info from anchored data for when that day comes?

Sure I can add a task for that

Copy link
Collaborator

@flagrede flagrede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@blushi blushi merged commit 83be5d3 into dev Nov 20, 2024
18 checks passed
@blushi blushi deleted the fix-APP-482-hide-useless-filters branch November 20, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants