Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: APP-477 various Terrasos design tweaks #2551

Merged
merged 15 commits into from
Nov 20, 2024

Conversation

flagrede
Copy link
Collaborator

@flagrede flagrede commented Nov 20, 2024

Description

Closes: APP-477

Various Terrasos design tweaks:

  • grid margins
  • checkbox filters layout
  • uppercase filter expand button
  • read more project story color
  • move stakeholders block and adjust spacing
  • change responsive slider buttons color
  • hide stakeholders if no data
  • documentation table colors
  • spanish translations tweaks
  • terrasos logo cut off

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

How to test

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for regen-website ready!

Name Link
🔨 Latest commit 3dd9b5b
🔍 Latest deploy log https://app.netlify.com/sites/regen-website/deploys/673df8228a2d2f00081c5d05
😎 Deploy Preview https://deploy-preview-2551--regen-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@flagrede flagrede requested review from blushi and wgardiner November 20, 2024 10:44
Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for terrasos ready!

Name Link
🔨 Latest commit 3dd9b5b
🔍 Latest deploy log https://app.netlify.com/sites/terrasos/deploys/673df822a78c8400083ef041
😎 Deploy Preview https://deploy-preview-2551--terrasos.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@flagrede flagrede changed the title fix: APP-477 various Terrasos fixes fix: APP-477 various Terrasos design tweaks Nov 20, 2024
@flagrede
Copy link
Collaborator Author

@erikalogie You can check out the various design tweaks here:
Projects: https://deploy-preview-2551--terrasos.netlify.app/projects/1
Project page: https://deploy-preview-2551--terrasos.netlify.app/project/C02-009

Copy link
Member

@blushi blushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one comment and some missing translations:

image

>
{isExpanded[index] ? labels.collapse : labels.expand}
</ButtonBase>
)}

<Divider sx={{ my: 5 }} />
Copy link
Member

@blushi blushi Nov 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should only be removed for the last filter section, not for all, see design https://www.figma.com/design/brkxGV5qNOkZUp0YQl1cxO/Terrasos-Phase-1?node-id=1204-174906&node-type=instance&m=dev

@S4mmyb
Copy link
Member

S4mmyb commented Nov 20, 2024

Thanks @flagrede ! I'm noticing the logo is still a bit cut off in both the english and spanish versions. Also, and sorry i missed this one before, it looks like we have another small language tweak on the header. "Home" should actually translate to "INICIO" rather than "HOGAR" (link to line here). I think the translation worked correctly, but they just use the word start for the homepage instead - probably a regional thing.

Copy link
Member

@blushi blushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flagrede
Copy link
Collaborator Author

flagrede commented Nov 20, 2024

@S4mmyb The logo should be good now. It was a bit tricky to get the full size while matching the exact position between the two sites since we're using an SVG and they're using several PNGs.

@erikalogie
Copy link
Collaborator

This looks so good, the only last thing that might be nice to add to this PR is to hide the pagination altogether if there are less than 9 projects, otherwise it is just taking up space unnecessarily. I can also open a separate task for that if you'd rather close this PR @flagrede

@flagrede
Copy link
Collaborator Author

flagrede commented Nov 20, 2024

@erikalogie It's ok, I have handled that in the PR.

@flagrede flagrede force-pushed the fix-APP-477-color-design-tweaks branch from fff6916 to c979e53 Compare November 20, 2024 14:53
@flagrede flagrede force-pushed the fix-APP-477-color-design-tweaks branch from c979e53 to 3dd9b5b Compare November 20, 2024 14:54
@flagrede flagrede merged commit 772f925 into dev Nov 20, 2024
18 checks passed
@flagrede flagrede deleted the fix-APP-477-color-design-tweaks branch November 20, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants