-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: APP-477 various Terrasos design tweaks #2551
Conversation
✅ Deploy Preview for regen-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for terrasos ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@erikalogie You can check out the various design tweaks here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
> | ||
{isExpanded[index] ? labels.collapse : labels.expand} | ||
</ButtonBase> | ||
)} | ||
|
||
<Divider sx={{ my: 5 }} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should only be removed for the last filter section, not for all, see design https://www.figma.com/design/brkxGV5qNOkZUp0YQl1cxO/Terrasos-Phase-1?node-id=1204-174906&node-type=instance&m=dev
Thanks @flagrede ! I'm noticing the logo is still a bit cut off in both the english and spanish versions. Also, and sorry i missed this one before, it looks like we have another small language tweak on the header. "Home" should actually translate to "INICIO" rather than "HOGAR" (link to line here). I think the translation worked correctly, but they just use the word start for the homepage instead - probably a regional thing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@S4mmyb The logo should be good now. It was a bit tricky to get the full size while matching the exact position between the two sites since we're using an SVG and they're using several PNGs. |
This looks so good, the only last thing that might be nice to add to this PR is to hide the pagination altogether if there are less than 9 projects, otherwise it is just taking up space unnecessarily. I can also open a separate task for that if you'd rather close this PR @flagrede |
@erikalogie It's ok, I have handled that in the PR. |
fff6916
to
c979e53
Compare
c979e53
to
3dd9b5b
Compare
Description
Closes: APP-477
Various Terrasos design tweaks:
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
How to test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...