Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: APP-487 sanity localized data fallback #2552

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

flagrede
Copy link
Collaborator

@flagrede flagrede commented Nov 20, 2024

Description

Closes: APP-487

Fix Sanity localized data fallback.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

How to test

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for regen-website ready!

Name Link
🔨 Latest commit c2e5aa9
🔍 Latest deploy log https://app.netlify.com/sites/regen-website/deploys/673e16f62d9af500088cc90b
😎 Deploy Preview https://deploy-preview-2552--regen-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@flagrede flagrede requested a review from blushi November 20, 2024 17:07
Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for terrasos ready!

Name Link
🔨 Latest commit c2e5aa9
🔍 Latest deploy log https://app.netlify.com/sites/terrasos/deploys/673e16f60cd2a20008ba2cf0
😎 Deploy Preview https://deploy-preview-2552--terrasos.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

blushi
blushi approved these changes Nov 21, 2024
@blushi
Copy link
Member

blushi commented Nov 21, 2024

@erikalogie you can check out this project credibility card, switch to spanish https://deploy-preview-2552--terrasos.netlify.app/project/test-terrasos-project-2

@erikalogie
Copy link
Collaborator

LGTM!

@blushi blushi merged commit 15d90c3 into dev Nov 21, 2024
18 checks passed
@blushi blushi deleted the fix-APP-487-fix-sanity-localized-data-fallback branch November 21, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants