Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: APP-497 project filters overflow #2562

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

flagrede
Copy link
Collaborator

@flagrede flagrede commented Nov 26, 2024

Description

Closes: APP-497

Fix project filters buttons overflow.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

How to test

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

@flagrede flagrede requested a review from blushi November 26, 2024 14:46
Copy link

netlify bot commented Nov 26, 2024

Deploy Preview for regen-website ready!

Name Link
🔨 Latest commit 36c6ab5
🔍 Latest deploy log https://app.netlify.com/sites/regen-website/deploys/6745fb5e3a0bed0008a07a68
😎 Deploy Preview https://deploy-preview-2562--regen-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@blushi
Copy link
Member

blushi commented Nov 26, 2024

FYI looks like it's fixing APP-497, not 502

Copy link

netlify bot commented Nov 26, 2024

Deploy Preview for terrasos ready!

Name Link
🔨 Latest commit 36c6ab5
🔍 Latest deploy log https://app.netlify.com/sites/terrasos/deploys/6745fb5ec70d620008557980
😎 Deploy Preview https://deploy-preview-2562--terrasos.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@flagrede flagrede changed the title fix: project filters overflow fix: 497 project filters overflow Nov 26, 2024
@flagrede flagrede changed the title fix: 497 project filters overflow fix: APP-497 project filters overflow Nov 26, 2024
@flagrede
Copy link
Collaborator Author

FYI looks like it's fixing APP-497, not 502

Yes you're right!

@flagrede
Copy link
Collaborator Author

@erikalogie You can check that the button partially visible has been hidden entirely now: https://deploy-preview-2562--terrasos.netlify.app/projects/1

@erikalogie
Copy link
Collaborator

LGTM

@blushi blushi force-pushed the fix-APP-502-overflow-filters-buttons branch from c2e01a5 to 36c6ab5 Compare November 26, 2024 16:46
@blushi blushi enabled auto-merge (squash) November 26, 2024 16:46
@blushi blushi merged commit a1ad892 into dev Nov 26, 2024
11 of 14 checks passed
@blushi blushi deleted the fix-APP-502-overflow-filters-buttons branch November 26, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants