Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: APP-383 align create project button #2568

Merged
merged 3 commits into from
Dec 11, 2024
Merged

Conversation

r41ph
Copy link
Contributor

@r41ph r41ph commented Dec 9, 2024

Description

https://regennetwork.atlassian.net/browse/APP-383

Author Checklist

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

How to test

  1. Check '+ Create project' button is aligned as expected both when users are logged in and not logged in.
    => https://deploy-preview-2568--regen-marketplace.netlify.app/

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

Copy link

netlify bot commented Dec 9, 2024

Deploy Preview for terrasos ready!

Name Link
🔨 Latest commit 630d6b7
🔍 Latest deploy log https://app.netlify.com/sites/terrasos/deploys/67580612638e7a0008cf334d
😎 Deploy Preview https://deploy-preview-2568--terrasos.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 9, 2024

Deploy Preview for regen-website ready!

Name Link
🔨 Latest commit 630d6b7
🔍 Latest deploy log https://app.netlify.com/sites/regen-website/deploys/675806122df5fd000897360e
😎 Deploy Preview https://deploy-preview-2568--regen-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@r41ph r41ph requested a review from blushi December 9, 2024 12:33
@blushi
Copy link
Member

blushi commented Dec 9, 2024

I know this wasn't part of the task, but we should probably also adjust the language switcher position. Now that "create project" is aligned with the menu items on the left, it looks quite bad when user is logged in:
image

Is this a quick fix or should we create another task?

I think the actual issue is that when logged in, the menu items are not centered vertically:

image

@r41ph
Copy link
Contributor Author

r41ph commented Dec 9, 2024

Is this a quick fix or should we create another task?

I think it'd probably be easier to do it in this task. I'll have a quick look and let you know.

@r41ph
Copy link
Contributor Author

r41ph commented Dec 9, 2024

@erikalogie @blushi please have a look, I have aligned the language switcher too.

@r41ph r41ph force-pushed the APP-383-create-project-button branch from f21209c to 630d6b7 Compare December 10, 2024 09:12
@erikalogie
Copy link
Collaborator

LGTM!

@r41ph r41ph merged commit d0457d3 into dev Dec 11, 2024
18 checks passed
@r41ph r41ph deleted the APP-383-create-project-button branch December 11, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants