Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: APP-528 registered credits in compliance credits tab #2569

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

blushi
Copy link
Member

@blushi blushi commented Dec 9, 2024

Description

https://regennetwork.atlassian.net/browse/APP-528


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

How to test

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

@blushi blushi requested a review from r41ph December 9, 2024 13:18
Copy link

netlify bot commented Dec 9, 2024

Deploy Preview for regen-website ready!

Name Link
🔨 Latest commit b6f5851
🔍 Latest deploy log https://app.netlify.com/sites/regen-website/deploys/675716bbf6f5f4000819cc3f
😎 Deploy Preview https://deploy-preview-2569--regen-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 9, 2024

Deploy Preview for terrasos ready!

Name Link
🔨 Latest commit b6f5851
🔍 Latest deploy log https://app.netlify.com/sites/terrasos/deploys/675716bb54de350007d99b44
😎 Deploy Preview https://deploy-preview-2569--terrasos.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@blushi
Copy link
Member Author

blushi commented Dec 9, 2024

@erikalogie
Copy link
Collaborator

LGTM

@S4mmyb
Copy link
Member

S4mmyb commented Dec 9, 2024

Thanks for the quick turnaround @blushi! Is the logic here that registered amount = tradeable + retired? Or do we pull the registered amount directly from sanity

@blushi
Copy link
Member Author

blushi commented Dec 9, 2024

Thanks for the quick turnaround @blushi! Is the logic here that registered amount = tradeable + retired? Or do we pull the registered amount directly from sanity

The logic was still the one used for regular on chain credits where we display tradable + retired as "Credits issued"
But this doesn't seem to apply to registered compliance credits so now we just display the registered amount from sanity directly

@blushi blushi force-pushed the feat-APP-528-compliance-credits branch from 5cfed1c to b6f5851 Compare December 9, 2024 16:11
@blushi blushi merged commit 49c42cd into dev Dec 10, 2024
18 checks passed
@blushi blushi deleted the feat-APP-528-compliance-credits branch December 10, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants