Switch theme #includes from absolute paths to relative
#17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes themes more portable! `#include`s in Xresources configuration files are [C preprocessing directives](https://gcc.gnu.org/onlinedocs/cpp/Include-Syntax.html), which first look in the same directory as the current file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes themes more portable!
#includes in Xresources configuration files areC preprocessing directives, which first look in the same directory as the current file.
There are still a good number of Xresources config values here that are absolute paths, like the wallpaper path, so themes aren't fully portable with this change. To me this mainly improves the testing experience.
@kgilmer this is my (very) late follow up on this discussion.