Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SendDeathMessage kill rarity flags and transform to VFUNC #943

Merged
merged 5 commits into from
May 8, 2024
Merged

Fix SendDeathMessage kill rarity flags and transform to VFUNC #943

merged 5 commits into from
May 8, 2024

Conversation

FEDERICOMB96
Copy link
Contributor

This solves some problems detected during the testing of the hook "RG_CSGameRules_SendDeathMessage" and is totally linked to rehlds/ReAPI#305

@FEDERICOMB96 FEDERICOMB96 mentioned this pull request Feb 8, 2024
Merged
@FEDERICOMB96 FEDERICOMB96 changed the title Fixed SendDeathMessage kill rarity flags and transform to VFUNC Fix SendDeathMessage kill rarity flags and transform to VFUNC Feb 13, 2024
@Nord1cWarr1or
Copy link
Contributor

some problems

Can you describe these problems?

@FEDERICOMB96
Copy link
Contributor Author

some problems

Can you describe these problems?

Modify iRarityOfKill and iDeathMessageFlags vars inside SendDeathMessage function, amxx hook can't detect it.

Replace pVictim->m_bHeadshotKilled with iRarityOfKill & KILLRARITY_HEADSHOT is only for complete functionality of native rg_send_death_message and being able to change its value through the hook.

@s1lentq s1lentq merged commit 8ec5b6c into rehlds:master May 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FEDERICOMB96 @Nord1cWarr1or @s1lentq