Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dependency] update bzip2 1.0.6 -> 1.0.8 #1066

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Dependency] update bzip2 1.0.6 -> 1.0.8 #1066

wants to merge 1 commit into from
+5,174 −5,176

Conversation

stamepicmorg
Copy link
Contributor

@stamepicmorg stamepicmorg commented Nov 19, 2024 •
edited
Loading

Just updated bzip2 from 1.0.6 to 1.0.8.

No exploit fixes, just library update.

for historical purposes
1.0.8.linux32.zip
1.0.8.win32.zip

@stamepicmorg stamepicmorg added the Type: 🛑 dependency Routine tasks, maintenance, or non-user-facing changes. label Nov 19, 2024
@stamepicmorg stamepicmorg self-assigned this Nov 19, 2024
@stamepicmorg stamepicmorg added Engine: 📺 reHLTV Case refers to reHLDS version. Engine: 📀 reHLDS Case refers to reHLDS engine. Priority: 🕒 low Low priority tasks that can be postponed for the future. Status: 👀 needs review Requires code or changes review. Difficulty: 🟡 medium Task of medium difficulty requiring moderate effort. OS: 💻 Independent Case do not refer to any OS. labels Nov 21, 2024
@stamepicmorg
Copy link
Contributor Author

@s1lentq hello. We are tested this version in live server with you. Could you please review this pr?

@di57inct
Copy link

this update has caused issues with teams and chat command hooks on my cs servers and caused a server hang. rolled back to the first zip bomb exploit fix.

@stamepicmorg
Copy link
Contributor Author

this update has caused issues with teams and chat command hooks on my cs servers and caused a server hang. rolled back to the first zip bomb exploit fix.

@di57inct

this commit just updates 10yo dependency (2014year of release) to more fresh version (released in 2019). there is no any exploit fixes. just bzip lib update.

are you shure, that previous version from master CI will not cause your problems too as this test build?

@stamepicmorg stamepicmorg changed the title bzip2 1.0.6 -> 1.0.8 [Dependency] updatebzip2 1.0.6 -> 1.0.8 Nov 21, 2024
@stamepicmorg stamepicmorg changed the title [Dependency] updatebzip2 1.0.6 -> 1.0.8 [Dependency] update bzip2 1.0.6 -> 1.0.8 Nov 21, 2024
@di57inct
Copy link

di57inct commented Nov 21, 2024 •
edited
Loading

this update has caused issues with teams and chat command hooks on my cs servers and caused a server hang. rolled back to the first zip bomb exploit fix.

@di57inct

this commit just updates 10yo dependency (2014year of release) to more fresh version (released in 2019). there is no any exploit fixes. just bzip lib update.

are you shure, that previous version from master CI will not cause your problems too as this test build?

Protocol version 48
Exe version 1.1.2.7/Stdio (cstrike)
ReHLDS version: 3.14.0.0-dev
Build date: 11:33:30 Nov 19 2024 (3874)
Build from:

works just fine.
https://github.com/rehlds/ReHLDS/actions/runs/11912161264 doesn't. causes amxx chat hook via register_clcmd to partially not work. for example if i say rr it works but if i say warm it doesn't.
rest of the stuff running on the server is:

Metamod-r v1.3.0.149, API (5:13)
Metamod-r build: 11:31:17 Apr 23 2024
Metamod-r from: rehlds/Metamod-R@603a257
Currently loaded plugins:
description stat pend file vers src load unload
[ 1] YaPB RUN - yapb.so v4.5.1117 ini Chlvl ANY
[ 2] SafeNameAndChat RUN - SafeNameAndChat.so v1.1 ini ANY ANY
[ 3] Reunion RUN - reunion_mm_i386.so v0.2.0.13 ini Start Never
[ 4] HitBox Fix RUN - hitbox_fix_mm_i386.so v1.1.4 ini Start ANY
[ 5] WHBlocker RUN - whblocker_mm_i386.so v1.5.697 ini Chlvl ANY
[ 6] AMX Mod X RUN - amxmodx_mm_i386.so v1.10.0.5467 ini Start ANY
[ 7] ReAPI RUN - reapi_amxx_i386.so v5.24.0.300-dev pl6 ANY Never
[ 8] Engine RUN - engine_amxx_i386.so v1.10.0.5467 pl6 ANY ANY
[ 9] FakeMeta RUN - fakemeta_amxx_i386.so v1.10.0.5467 pl6 ANY ANY
[10] CStrike RUN - cstrike_amxx_i386.so v1.10.0.5467 pl6 ANY ANY
[11] Ham Sandwich RUN - hamsandwich_amxx_i386.so v1.10.0.5467 pl6 ANY ANY
[12] CSX RUN - csx_amxx_i386.so v1.10.0.5467 pl6 ANY ANY
[13] GeoIP RUN - geoip_amxx_i386.so v1.10.0.5467 pl6 ANY ANY
[14] Fun RUN - fun_amxx_i386.so v1.10.0.5467 pl6 ANY ANY
[15] MySQL RUN - mysql_amxx_i386.so v1.10.0.5467 pl6 ANY ANY
15 plugins, 15 running

even caused a server hang after a couple of hours. had over 1 month server uptime before so no other mods caused it. when i rolled back everything went back to normal with no issues.

@stamepicmorg
Copy link
Contributor Author

stamepicmorg commented Nov 21, 2024 •
edited
Loading

@di57inct this updated part used by engine only if you download resources without fastdl.

how it crash your server, if there is no engine's sources was modified?

there is no breaking changes at all.

by the way, this pr still in testing.

Please, provide more info:

➡️ What version of engine are you seeing the problem on?

➡️ Please, paste output from console command below:
version; game version; meta version; meta list

➡️ (Optional) You could also provide info about AMX Mox X (version < 1.9.0 are not supported!):
amxx version; amxx plugins

➡️ Your environment: OS ( 🪟 Windows or 🐧 Linux), OS Vetsion, etc.

@di57inct
Copy link

di57inct commented Nov 21, 2024 •
edited
Loading

EDIT: I do seem to have a missing resource if that helps with anything; "Error: server failed to transmit file 'sound/radio/bot/im_blind.wav'"

Server doesn't crash, it hangs(100% cpu usage and no response).

Server engine version is latest steam_legacy(pre-25th). Not running ReGameDLL.
OS is Debian 12(don't know how to get exact version). Rest of the required info:

Protocol version 48
Exe version 1.1.2.7/Stdio (cstrike)
ReHLDS version: 3.14.0.0-dev
Build date: 11:33:30 Nov 19 2024 (3874)
Build from: 
Metamod-r v1.3.0.149, API (5:13)
Metamod-r build: 11:31:17 Apr 23 2024
Metamod-r from: https://github.com/theAsmodai/metamod-r/commit/603a257
Currently loaded plugins:
      description      stat pend  file                      vers             src  load  unload
 [ 1] YaPB             RUN   -    yapb.so                   v4.5.1117        ini  Chlvl ANY  
 [ 2] SafeNameAndChat  RUN   -    SafeNameAndChat.so        v1.1             ini  ANY   ANY  
 [ 3] Reunion          RUN   -    reunion_mm_i386.so        v0.2.0.13        ini  Start Never
 [ 4] HitBox Fix       RUN   -    hitbox_fix_mm_i386.so     v1.1.4           ini  Start ANY  
 [ 5] WHBlocker        RUN   -    whblocker_mm_i386.so      v1.5.697         ini  Chlvl ANY  
 [ 6] AMX Mod X        RUN   -    amxmodx_mm_i386.so        v1.10.0.5467     ini  Start ANY  
 [ 7] ReAPI            RUN   -    reapi_amxx_i386.so        v5.24.0.300-dev  pl6  ANY   Never
 [ 8] Engine           RUN   -    engine_amxx_i386.so       v1.10.0.5467     pl6  ANY   ANY  
 [ 9] FakeMeta         RUN   -    fakemeta_amxx_i386.so     v1.10.0.5467     pl6  ANY   ANY  
 [10] CStrike          RUN   -    cstrike_amxx_i386.so      v1.10.0.5467     pl6  ANY   ANY  
 [11] Ham Sandwich     RUN   -    hamsandwich_amxx_i386.so  v1.10.0.5467     pl6  ANY   ANY  
 [12] CSX              RUN   -    csx_amxx_i386.so          v1.10.0.5467     pl6  ANY   ANY  
 [13] GeoIP            RUN   -    geoip_amxx_i386.so        v1.10.0.5467     pl6  ANY   ANY  
 [14] Fun              RUN   -    fun_amxx_i386.so          v1.10.0.5467     pl6  ANY   ANY  
 [15] MySQL            RUN   -    mysql_amxx_i386.so        v1.10.0.5467     pl6  ANY   ANY  
15 plugins, 15 running
AMX Mod X 1.10.0.5467 (http://www.amxmodx.org)
Authors:
        David "BAILOPAN" Anderson, Pavol "PM OnoTo" Marko
        Felix "SniperBeamer" Geyer, Jonny "Got His Gun" Bergstrom
        Lukasz "SidLuke" Wlasinski, Christian "Basic-Master" Hammacher
        Borja "faluco" Ferrer, Scott "DS" Ehlert
Compiled: Jan 21 2023 20:27:33
Built from: https://github.com/alliedmodders/amxmodx/commit/27f451a
Build ID: 5467:27f451a
Core mode: JIT+ASM32
Currently loaded plugins:
       id  name                    version     author            url                              file         status   
 [  1] 0   Advanced Bans           0.8.1       Exolent                                            advanced_ba  running  
 [  2] 1   Admin Base              1.10.0.546  AMXX Dev Team                                      admin.amxx   running  
 [  3] 2   Admin Commands          1.10.0.546  AMXX Dev Team                                      admincmd.am  running  
 [  4] 3   Admin Help              1.10.0.546  AMXX Dev Team                                      adminhelp.a  running  
 [  5] 4   Slots Reservation       1.10.0.546  AMXX Dev Team                                      adminslots.  running  
 [  6] 5   Multi-Lingual System    1.10.0.546  AMXX Dev Team                                      multilingua  running  
 [  7] 6   Menus Front-End         1.10.0.546  AMXX Dev Team                                      menufront.a  running  
 [  8] 7   Commands Menu           1.10.0.546  AMXX Dev Team                                      cmdmenu.amx  running  
 [  9] 8   Players Menu            1.10.0.546  AMXX Dev Team                                      plmenu_ab_b  running  
 [ 10] 9   Teleport Menu           1.10.0.546  AMXX Dev Team                                      telemenu.am  running  
 [ 11] 10  Maps Menu               1.10.0.546  AMXX Dev Team                                      mapsmenu.am  running  
 [ 12] 11  Plugin Menu             1.10.0.546  AMXX Dev Team                                      pluginmenu.  running  
 [ 13] 12  Anti Flood              1.10.0.546  AMXX Dev Team                                      antiflood.a  running  
 [ 14] 13  Admin Votes             1.10.0.546  AMXX Dev Team                                      adminvote.a  running  
 [ 15] 14  Pause Plugins           1.10.0.546  AMXX Dev Team                                      pausecfg.am  running  
 [ 16] 15  Stats Configuration     1.10.0.546  AMXX Dev Team                                      statscfg.am  running  
 [ 17] 16  Restrict Weapons        1.10.0.546  AMXX Dev Team                                      restmenu.am  running  
 [ 18] 17  StatsX                  1.10.0.546  AMXX Dev Team                                      statsx.amxx  running  
 [ 19] 18  D7 ReAPI Block Status   0.0.1       D7                                                 D7REBlockSt  running  
 [ 20] 19  Advanced Weapon Tracer  1.3.0       ConnorMcLeod                                       advanced_we  running  
 [ 21] 20  CSDM Teambalancer       1.2.9       DA, D i 5 7 i n                                    csdm_teamba  running  
 [ 22] 21  GunGame AMXX            2.17o       Avalanche                                          gungame.amx  running  
 [ 23] 22  D7 Auto spawn on conne  0.0.2       D i 5 7 i n c T                                    D7AutoConne  running  
 [ 24] 23  D7 Item MultiJump       0.1.3       twistedeuphoria,                                   D7MultiJump  running  
 [ 25] 24  Map Manager: Core       3.3.1       Mistrick                                           map_manager  running  
 [ 26] 25  Map Manager: Scheduler  0.2.4       Mistrick                                           map_manager  running  
 [ 27] 26  Map Manager: Rtv        0.1.5       Mistrick                                           map_manager  running  
 [ 28] 27  Map Manager: Nominatio  0.3.5       Mistrick                                           map_manager  running  
 [ 29] 28  Map Manager: BlockList  0.0.4       Mistrick                                           map_manager  running  
 [ 30] 29  Map Manager: Online so  0.0.4       Mistrick                                           map_manager  running  
 [ 31] 30  Map Manager: Effects    0.1.3       Mistrick                                           map_manager  running  
 [ 32] 31  Map Manager: Informer   0.0.5       Mistrick                                           map_manager  running  
 [ 33] 32  Map Manager: Sounds     0.0.3       Mistrick                                           map_manager  running  
 [ 34] 33  Map Manager: Online ch  1.0.3       Sergey Shorokhov                                   map_manager  running  
 [ 35] 34  [AMXX] Settings API     1.0         MeRcyLeZZ                                          amx_setting  running  
 [ 36] 35  [CS] Ham Hooks for Bot  1.0         WiLS                                               cs_ham_bots  running  
 [ 37] 36  [CS] Player Models API  1.2.2       WiLS              unknown                          cs_player_m  running  
 [ 38] 37  [CS] Weapon Models API  1.1         WiLS                                               cs_weap_mod  running  
 [ 39] 38  D7 (Dis)Connect Messag  1.5.1       D i 5 7 i n c T                                    D7(Dis)conn  running  
 [ 40] 39  D7 Admin free look      0.0.2       D i 5 7 i n c T                                    D7AdminFree  running  
 [ 41] 40  D7 Bot Gameplay         0.1.9       D7                                                 D7BotGamepl  running  
 [ 42] 41  D7 Bot Quota            0.1.0       D i 5 7 i n c T                                    D7BotQuota.  running  
 [ 43] 42  D7 Camera               0.2.3       XunTric, D i 5 7  unknown                          D7Camera.am  running  
 [ 44] 43  D7 HostName Scroll      0.0.3       D i 5 7 i n c T                                    D7HostNameS  running  
 [ 45] 44  D7 HUD Info             1.0.9       D i 5 7 i n c T                                    D7HUDInfo.a  running  
 [ 46] 45  D7 HUD Info Spec        0.0.1       ConnorMcLeod, D7  unknown                          D7HUDInfoSp  debug    
 [ 47] 46  D7 Kill assist          1.1.9       D i 5 7 i n c T,                                   D7KillAssis  paused   
 [ 48] 47  D7 nick changer         1.2.2       D i 5 7 i n c T                                    D7NameChang  running  
 [ 49] 48  No Radio Flood          1.1.7       Starsailor, rega                                   D7NoRadioFl  running  
 [ 50] 49  D7 Parachute            0.0.1       D i 5 7 i n c T                                    D7Parachute  running  
 [ 51] 50  D7 Remember weapon sil  0.0.5       D7                                                 D7RememberW  running  
 [ 52] 51  D7 Reset Score          1.0.2       D i 5 7 i n c T                                    D7ResetScor  running  
 [ 53] 52  D7 Spawn Features       0.0.3       D i 5 7 i n c T                                    D7SpawnFeat  running  
 [ 54] 53  D7 TicRate Optimizer    0.0.2       D7                                                 D7TicRateOp  debug    
 [ 55] 54  [ZPNM] Anti Spectator   1.0.2       D i 5 7 i n c T   unknown                          zpnm_gp_ant  running  
 [ 56] 55  [ZPNM] Damage Displaye  0.3.2       D i 5 7 i n c T                                    zpnm_gp_hud  running  
 [ 57] 56  Advanced Mute           2.1         OciXCrom                                           crx_advmute  running  
 [ 58] 57  OciXCrom's Admin Chat   4.2         OciXCrom                                           crx_adminch  running  
 [ 59] 58  CM: Toggle Chat         4.1         OciXCrom                                           crx_chatman  running  
 [ 60] 59  Command Targeting Plus  1.3         OciXCrom                                           crx_cmdtarg  running  
 [ 61] 60  Command Restrictions    2.1         OciXCrom                                           crx_command  running  
 [ 62] 61  Simple Demo Recorder    2.0.3       OciXCrom          unknown                          crx_demorec  running  
 [ 63] 62  Ultimate Fire in the H  2.1         OciXCrom                                           crx_fireint  running  
 [ 64] 63  Game Messages & Sounds  3.0.2       OciXCrom                                           crx_gamemes  running  
 [ 65] 64  GoSpec                  1.2         OciXCrom                                           crx_gospec.  running  
 [ 66] 65  OciXCrom's Rank System  3.15        OciXCrom                                           crx_ranksys  running  
 [ 67] 66  Remove Immunity         1.0         OciXCrom                                           crx_remove_  running  
 [ 68] 67  Let it Snow!            1.0         OciXCrom                                           crx_snow.am  running  
 [ 69] 68  Spawn Protection        1.1.0       OciXCrom                                           crx_spawn_p  running  
 [ 70] 69  Accuracy Fix            3.0         Numb              unknown                          accuracy_fi  running  
 [ 71] 70  Autoresponder/Advertis  0.5         MaximusBrood                                       ad_manager.  running  
 [ 72] 71  Admin Spectator ESP     1.4_beta    KoST                                               admin_spec_  running  
 [ 73] 72  CS AFK Manager          1.0.6 (amx  Freeman                                            afk_manager  running  
 [ 74] 73  Auto Join on Connect    0.1         VEN                                                auto_join_o  running  
 [ 75] 74  Bomb/Death/CSS Radar    1.2         eDark & Numb      unknown                          css_radar.a  running  
 [ 76] 75  Dead Name Change        0.1         VEN                                                dead_name_c  running  
 [ 77] 76  Fail Spawns Protector   1.2         zmd94                                              fail_spawn_  running  
 [ 78] 77  Flash Remote Control    12.0        OT                                                 flashbang_r  running  
 [ 79] 78  Invisible Spectator     0.3         ConnorMcLeod                                       invisible_s  paused   
 [ 80] 79  No See Vars             0.1.0       ConnorMcLeod                                       no_see_vars  running  
 [ 81] 80  Ping Faker              1.6.4       MeRcyLeZZ                                          pingfaker_m  running  
 [ 82] 81  Chat Manager            4.8         OciXCrom                                           crx_chatman  running  
 [ 83] 82  [SCM] Entity Editor     1.3.0       schmurgel1983                                      scm_entity_  running  
 [ 84] 83  [CS] Team Semiclip      3.3.1       schmurgel1983                                      cs_team_sem  running  
84 plugins, 82 running

@stamepicmorg
Copy link
Contributor Author

EDIT: I do seem to have a missing resource if that helps with anything; "Error: server failed to transmit file 'sound/radio/bot/im_blind.wav'"

@di57inct

having a missing resource needed for work is not very good. I think it should be assumed that this is the reason for the hang, not the library update.

in any case, a pull request is not an issue. if you have problems in the future, you should create an issue. let's not flood here without evidence.

I have been running three servers for several days and they work fine with this build. testing continues.

regards

@di57inct
Copy link

di57inct commented Nov 22, 2024 •
edited
Loading

@di57inct

having a missing resource needed for work is not very good. I think it should be assumed that this is the reason for the hang, not the library update.

in any case, a pull request is not an issue. if you have problems in the future, you should create an issue. let's not flood here without evidence.

I have been running three servers for several days and they work fine with this build. testing continues.

regards

never had a server hang because of a missing sound file that isn't used with emit_sound. that should get looked at because it isn't normal.
anyway, i added the file and will try to test again with this version and give feedback.

@stamepicmorg
Copy link
Contributor Author

@di57inct
having a missing resource needed for work is not very good. I think it should be assumed that this is the reason for the hang, not the library update.
in any case, a pull request is not an issue. if you have problems in the future, you should create an issue. let's not flood here without evidence.
I have been running three servers for several days and they work fine with this build. testing continues.
regards

never had a server hang because of a missing sound file that isn't used with emit_sound. that should get looked at because it isn't normal. anyway, i added the file and will try to test again with this version and give feedback.

i agree. i will test too.

@SergeyShorokhov SergeyShorokhov added the Status: 🎮 testing Issue in testing stage. label Nov 24, 2024
@di57inct
Copy link

confirming over 5 days of uptime when no resource is missing.

@stamepicmorg
Copy link
Contributor Author

@di57inct hello! have any updates?

@di57inct
Copy link

@di57inct hello! have any updates?

Working fine when no resources missing. No crashes or any other issues as far as i know over 2 weeks uptime.

@stamepicmorg
Copy link
Contributor Author

@di57inct hello! have any updates?

Working fine when no resources missing. No crashes or any other issues as far as i know over 2 weeks uptime.

good news, thank you for feedback! 🤝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s1lentq s1lentq Awaiting requested review from s1lentq

@SergeyShorokhov SergeyShorokhov Awaiting requested review from SergeyShorokhov

Assignees

@stamepicmorg stamepicmorg

@s1lentq s1lentq

Labels
Difficulty: 🟡 medium Task of medium difficulty requiring moderate effort. Engine: 📀 reHLDS Case refers to reHLDS engine. Engine: 📺 reHLTV Case refers to reHLDS version. OS: 💻 Independent Case do not refer to any OS. Priority: 🕒 low Low priority tasks that can be postponed for the future. Status: 👀 needs review Requires code or changes review. Status: 🎮 testing Issue in testing stage. Type: 🛑 dependency Routine tasks, maintenance, or non-user-facing changes.
Projects
🤝 Community & UX Initiatives
Status: In review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stamepicmorg @di57inct @s1lentq @SergeyShorokhov