Added codesign and resources #1069
Conversation
- for Windows: rehlds/.github#30 and rehlds/.github#29 - for Linux: rehlds/.github#28
stamepicmorg
added
Priority: ⚠️ medium
| runs-on: ubuntu-latest | ||
| runs-on: ubuntu-24.04 |
There was a problem hiding this comment.
Why is this necessary in this PR?
ubuntu-latest - It is a tag, and it will automatically update to the system we need.
There was a problem hiding this comment.
just -latest tag leads to an outdated version. if you specify 24, then it is a little newer and it is also LTS
it is not critical. i could roll-back it.
There was a problem hiding this comment.
I heard that GitHub is planning to move ubuntu-latest to ubuntu-24.04 early next year or so.
There was a problem hiding this comment.
yep, and i think it very slow to wait. why not to update to next LTS now? it stable.
|
Tonight I will update PR. Do not merge it yet please. Tip We collectively came to the conclusion that signing each file inside the archive with .asc files is a bit redundant. For now, we'll just leave the signatures of the final archive and the native Windows ones. |
| - name: Get rcedit from chocolatey | ||
| run: | | ||
| choco install rcedit -y | ||
| shell: "pwsh" |
There was a problem hiding this comment.
| shell: "pwsh" |
AFAIK, there is no need to use the pwsh shell. Standard Git Bash is fully suitable for the tasks.
There was a problem hiding this comment.
a im not trust to git bash console at windows. PowerShell is more native.
Added signing of windows binaries, resolves Add signing of windows binaries .github#30
Added resource metainfo to windows binaries, resolves Add resource metainfo to windows binaries .github#29
Added signing for linux binaries, resolves Add signing for linux binaries .github#28
Caution
This is
infrastructureupdate! NO code and NO bugfixes was implemented atReHLDSat this PR.Also, I know that we have .rc files that are used to create binaries.
The problem is that we have not yet fully decided how their future will develop from a development point of view. Also, now there are only 2 .rc files that are built into hlds.exe and hltv.exe. All other dlls are built naked, which excites antiviruses.
For now, I have chosen to use rcedit, written by the Electron project, which can successfully read and edit resources in compiled files. Which is what I am actually doing.
For now, I suggest leaving it as is. To launch the mechanism. And optimize it in subsequent iterations of development, to move the progress forward a little.