Update DESCRIPTION #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsweger
reviewed
Feb 1, 2024
| Description: Versioned Data for COVID-19 | ||
| License: MIT | ||
| Imports: | ||
| dplyr, tibble, tidyr, MMWRweek, lubridate, purrr, magrittr, xml2, rvest, RSocrata, here, httr | ||
| dplyr, here, httr, lubridate, magrittr, MMWRweek, purrr, readr, RSocrata, rvest, tibble, tidyr, xml2 |
| @@ -21,7 +21,7 @@ jobs: | |||
| key: r-${{ hashFiles('DESCRIPTION') }} | |||
| - name: Install dependencies | |||
| run: | | |||
| install.packages(c("remotes","devtools","readr","covidcast")) | |||
| install.packages(c("remotes","devtools","covidcast")) | |||
There was a problem hiding this comment.
Is covidcast also something that should be listed in the "imports" section of the DESCRIPTION (vs "suggests")?
There was a problem hiding this comment.
Some thoughts:
- People could happily use this package without using any functionality that requires covidcast, so i'd rather not require installation of that package...?
- however, we should probably check for whether that package is installed before trying to use it, which I bet we don't right now. i'd move to file a separate issue for that.
Seem reasonable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.