iac-for-aws-resources poster #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsweger
reviewed
Dec 19, 2024
bsweger
reviewed
Dec 19, 2024
bsweger
reviewed
Dec 19, 2024
elray1
reviewed
Dec 19, 2024
matthewcornell
changed the title
bsweger
reviewed
Jan 7, 2025
There was a problem hiding this comment.
Thanks for putting this together! Is there anything explicitly out of scope for this project?
In addition to that question, I made a few notes about the pros/cons of possible solutions, it it sounds like completing that list might be part of the project itself? (i.e., we don't have to have it exactly right at this moment)
zkamvar
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
This looks good to me. I'm not familiar with the nuances between puulmi vs using boto3, but either one is better than manual configuration, so my vote is to let this go forward. Overall, I agree with Becky's comments.
I also made a minor suggestion to change to improve the readability of the diagram, but absolutely not a requirement.
zkamvar
approved these changes
Jan 8, 2025
bsweger
approved these changes
Jan 8, 2025
elray1
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've done my best to incorporate discussion on the slack thread. I took the template as inspiration for my headings - the ones here are not perfect, and I'm open to their being changed. I just needed to get something down. There are a few TODO items. Thanks!