Unsubscribe all listeners in Rails >= 7.1 #252
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
In the app I'm working on, we've (mostly) silenced logs in CI via
There are some tests that explicitly test logging, though, so for the duration of those test we drop the log level down back down to
:info
.While upgrading this app from Rails 7 to Rails 7.1, we saw some odd failures in these tests — both the Rails-default logs and the
rails_semantic_logger
logs were being printed. It seems to be due to the changes made in rails/rails#45796 to thelisteners_for
method, whichrails_semantic_logger
uses to unsubscribe existing log subscribers. In short:log_level = :fatal
, whenrails_semantic_logger
is first loaded,listeners_for
doesn't return the Rails-default log subscribers, since they're currently silencedDescription of changes
This PR uses
all_listeners_for
, where available, to ensure that currently-silenced subscribers also get unsubscribed.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.