RT: ALU: i8 multiplication #120
Open
+1,016
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wzmuda
force-pushed
the
wz/8b-arith-mul
branch
from
78eb482 to
7339b16
Compare
wzmuda
commented
Jan 6, 2025
wzmuda
commented
Jan 6, 2025
compiler-rt/src/alu/smul_with_overflow/smul_with_overflow_i8.cairo
Outdated
Show resolved
Hide resolved
wzmuda
force-pushed
the
wz/8b-arith-mul
branch
2 times, most recently
from
69de2e1 to
d650038
Compare
wzmuda
force-pushed
the
wz/8b-arith-mul
branch
4 times, most recently
from
c4370c6 to
96e7062
Compare
|
Is this ready for review / seems to be working, now? It looks that way, but I want to be sure given its history. (In the future, can we either use draft PRs or provide a "requires changes" self-review once we know something's not ready for merge, so we can avoid the confusing prior state this had?) |
|
@ktemkin it is ready and it was a draft all the time I was polishing the logic. I marked it as ready yesterday when I fixed the code. |
iamrecursion
approved these changes
Jan 14, 2025
Implement the following polyfill: - `__llvm_mul_i8_u8` Signed-off-by: Wojciech Zmuda <[email protected]>
Implement the following polyfill: - `__llvm_umul_with_overflow_i8_i8` Signed-off-by: Wojciech Zmuda <[email protected]>
Implement the following polyfill: - `__llvm_smul_with_overflow_i8_i8` Signed-off-by: Wojciech Zmuda <[email protected]> Co-authored-by: Kate Temkin <[email protected]>
wzmuda
force-pushed
the
wz/8b-arith-mul
branch
from
96e7062 to
97c27eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add the following polyfills:
Details
Checklist
scarb fmt.