Design the handling of function pointers #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamrecursion
force-pushed
the
wip/ara/global-pointers
branch
from
c3c3b24 to
3af45ce
Compare
iamrecursion
force-pushed
the
wip/ara/function-pointer-design
branch
from
4362877 to
3af45ce
Compare
iamrecursion
force-pushed
the
wip/ara/function-pointer-design
branch
from
f9efacc to
79fe1ad
Compare
iamrecursion
force-pushed
the
wip/ara/global-pointers
branch
from
3af45ce to
74c83a1
Compare
iamrecursion
force-pushed
the
wip/ara/function-pointer-design
branch
from
79fe1ad to
bee2b20
Compare
iamrecursion
force-pushed
the
wip/ara/global-pointers
branch
from
74c83a1 to
58ab052
Compare
iamrecursion
force-pushed
the
wip/ara/function-pointer-design
branch
from
bee2b20 to
a946b08
Compare
ktemkin
reviewed
Jan 14, 2025
iamrecursion
force-pushed
the
wip/ara/global-pointers
branch
from
58ab052 to
a0241a2
Compare
iamrecursion
force-pushed
the
wip/ara/function-pointer-design
branch
from
a946b08 to
7cdff40
Compare
iamrecursion
force-pushed
the
wip/ara/function-pointer-design
branch
2 times, most recently
from
f1e508d to
e2a2381
Compare
As we do not have the ability to arbitrarily set the program counter when compiling via FlatLowered, we have had to come up with a clever way to emulate calling functions via pointers in Hieratika. This PR includes that design, which makes certain assumptions that seem to hold for generic Rust code, but may do not hold for all LLVM IR. This makes it sufficient for an initial implementation, and for getting Rust code working, but may later see evolution to better support more complex notions of function pointers.
iamrecursion
force-pushed
the
wip/ara/function-pointer-design
branch
from
e2a2381 to
4586c3f
Compare
ktemkin
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As we do not have the ability to arbitrarily set the program counter when compiling via
FlatLowered, we have had to come up with a clever way to emulate calling functions via pointers in Hieratika.This PR includes that design, which makes certain assumptions that seem to hold for generic Rust code, but may do not hold for all LLVM IR. This makes it sufficient for an initial implementation, and for getting Rust code working, but may later see evolution to better support more complex notions of function pointers.
Details
Check it makes sense please! For @ktemkin please make sure I faithfully recorded it as we discussed it!
Checklist
scarb fmt.