Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiler-rt: alu: add division for i8 #130

Merged
merged 1 commit into from
Jan 23, 2025
Merged

compiler-rt: alu: add division for i8 #130

merged 1 commit into from
Jan 23, 2025

Conversation

wzmuda
Copy link
Contributor

@wzmuda wzmuda commented Jan 21, 2025

Summary

Implement the following polyfills:

  • __llvm_udiv_i8_i8
  • __llvm_sdiv_i8_i8

Details

Signed division is not trivial this time.

Checklist

  • Code is formatted by Rustfmt or scarb fmt.
  • Documentation has been updated if necessary.

@wzmuda wzmuda requested a review from a team as a code owner January 21, 2025 22:04
Implement the following polyfills:
- `__llvm_udiv_i8_i8`
- `__llvm_sdiv_i8_i8`

Signed-off-by: Wojciech Zmuda <[email protected]>
@iamrecursion iamrecursion added the enhancement New feature or request label Jan 22, 2025
Copy link
Collaborator

@iamrecursion iamrecursion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzmuda wzmuda merged commit 525a2bb into main Jan 23, 2025
10 checks passed
@wzmuda wzmuda deleted the wz/8b-arith-div branch January 23, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants