Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump lean and mathlib to 4.15.0 #32

Merged
merged 1 commit into from
Jan 13, 2025
Merged

chore: bump lean and mathlib to 4.15.0 #32

merged 1 commit into from
Jan 13, 2025

Conversation

mpenciak
Copy link
Contributor

@mpenciak mpenciak commented Jan 8, 2025

This PR bumps Lean to toolchain version 4.15.0 and correspondingly pins Mathlib to v4.15.0-patch1. Most required updates were largely mechanical.

The main changes this entails are:

  • Mathlib.Vector has been renamed to List.Vector
  • List, Array, and Vector deprecating versions of getNth
  • TacticM no longer automatically lifts Options? I needed to add a bunch of liftOptions to Tactic.SeparationLogic
  • tauto has always been a finishing tactic, and the instances of non-finishing tauto were not being flagged in 4.12.0 for some reason. A simple fix was to replace tauto -> try tauto, but maybe a more principled approach is worth exploring.
  • rfl doesn't see through decomposeToRadix anymore for some reason? There's a few ways to make the examples in the Builtin.Helpers file, and depending on the importance of the change it may be worth thinking about.

Things that need to be done before this is mergeable:

@mpenciak mpenciak marked this pull request as ready for review January 13, 2025 19:20
@mpenciak mpenciak requested a review from utkn January 13, 2025 19:21
Copy link
Contributor

@utkn utkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

@mpenciak mpenciak merged commit b832e0f into main Jan 13, 2025
6 checks passed
@mpenciak mpenciak deleted the mp/bump-mathlib branch January 13, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants