Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calibration Support for negative slopes. #53

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SparkRocketLab
Copy link

See https://www.rocketryforum.com/threads/rmts-a-combined-daq-and-ignition-system.155649/post-2629818 for breakdown of PR.

This PR also updates the versions of some libraries. This specifies a version or SciPy for the first time in requirements.txt and updates PyQT5 and Matplotlib to the latest versions.

The calibration program will currently input values and
calculate the regression line like it's doing it correctly,
but the negative slope will always default to 0.00000001
instead of the correct value. This commit fixes that by
setting the minimum value to allow negative numbers.
Copy link
Owner

@reilleya reilleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will approve once I have a moment to test with my own system to make sure nothing broke. Have a quick summary of what you tested?

Thanks for cleaning up the dependencies!

@SparkRocketLab
Copy link
Author

So far, I've tested:

  • every main screen. Connected to the RMTS and went through the main functions.
  • Performed 3 new motor fires.
  • Went through the calibration process numerous times.
  • Viewed saved data and exported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants