More options #52
Open
More options #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VHPL-UIS
reviewed
Oct 3, 2023
| } else { | ||
| // Important fix: Reduce debt here, since it debt will be added again below. | ||
| // Idea is, paying for the current request should not effect the edge balance. | ||
| newEdgeData1 := edgeData1 | ||
| newEdgeData1.A2B = edgeData1.A2B - price | ||
| state.Graph.SetEdgeData(payment.FirstNodeId, payment.PayNextId, newEdgeData1) |
There was a problem hiding this comment.
Here, you have removed some code while Arman had them in the latest version he pushed. Should we keep your code? @leandernikolaus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cointains some more options for paying and generating networks:
Refactoring:
Configurable config options
RouteOnlyNearestwill always use the neighbor closest to the chunk, even if others have free bandwidth and this one needs to be payed.VariableRefreshrateincreases and decreases the refreshrate on paying and refreshing. Not sure this is useful. Should probably be removed.Command line options
confparameter allows to specify a specific config file. I find this useful, when I need to plan multiple runs, because I can run them without changing the config file in between, e.g.:Options for network generation
config: tell the tool to use network size, bin size and bits from a configuration file.conffile: give the relative path to a config file to be used.-random=falseoptions is used together with the-configthe tool will use the second choice rule for generating node Ids. In this rule, for every node, two random IDs are chosen and the one with fewer peers already in the neighborhood is chosen.See also
generate_network_data/README.md.