Added mapping for final releasever override [RHELDST-19153] #44
+50
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbikar
force-pushed
the
add-override-final-relver
branch
from
e748924
to
c636572
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #44 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 75 75
=========================================
Hits 75 75 ☔ View full report in Codecov by Sentry. |
rbikar
force-pushed
the
add-override-final-relver
branch
4 times, most recently
from
eaec9bb
to
40cf897
Compare
MichalHaluza
previously approved these changes
Sep 14, 2023
rohanpm
previously approved these changes
Sep 14, 2023
src/cdn_definitions/schema.json
Outdated
| @@ -44,6 +44,22 @@ | |||
| }, | |||
| "type": "object" | |||
| }, | |||
| "content_set_label": { | |||
| "pattern": "^[A-Za-z0-9_\\-]{1,100}$", | |||
There was a problem hiding this comment.
I'm just wondering if 100 chars might be a bit short? I checked our current data and the current longest label seems to be 74 chars already: ansible-automation-platform-2.0-early-access-for-rhel-8-x86_64-source-rpms
So, that's not much room to grow.
When I'm in doubt about upper limits I usually set them to at least 2x the currently known max.
There was a problem hiding this comment.
update the cs pattern to:
"pattern": "^[A-Za-z0-9_\\-]{1,200}$",
Added support for definition of override for final releasever by content set label. Additionally the pre-commit re-organized json files a bit.
rbikar
force-pushed
the
add-override-final-relver
branch
from
40cf897
to
2a3e2a3
Compare
|
did only small update to cs patter - carrying over +1s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for definition of override for final releasever
by content set label.
Additionally the pre-commit re-organized json files a bit.