Add tests to verify current schema is backward compatible #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All schema changes ought to be backwards compatible, as any usage would be prone to break any upgrade to cdn-definitions. Hence, add the test to validate historical data against current schema. The historical data in tests/historical-data are the data.yamls that were present preceding any schema updates i.e. data-1.0.0.yaml has that data that was present when the schema was updated in v2.0.0., so the test could validate the old data against this updated schema.
rajulkumar
requested review from
rohanpm,
rbikar and
crungehottman
as code owners
rohanpm
approved these changes
Sep 10, 2024
crungehottman
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All schema changes ought to be backwards compatible, as any usage would be prone to break any upgrade to cdn-definitions. Hence, add the test to validate historical data against current schema.
The historical data in tests/historical-data are the data.yamls that were present preceding any schema updates i.e. data-1.0.0.yaml has that data that was present when the schema was updated in v2.0.0., so the test could validate the old data against this updated schema. The files were named as per the cdn-definitions version when there was an update in the schema.