Reduce boto connect/read timeouts [RHELDST-21242] #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default value of connect_timeout and read_timeout in boto is 60 seconds. Our lambdas timeout after 15 seconds. There's no reason for the inner timeouts to exceed the outer and reducing the inner timeouts may prove more helpful in debugging.
|
Hold on this until CDN config changes are in place. |
rohanpm
approved these changes
Nov 2, 2023
| @@ -93,6 +110,8 @@ required: | |||
| - table | |||
| - config_table | |||
| - config_cache_ttl | |||
| - connect_timeout | |||
There was a problem hiding this comment.
Note that adding these as "required" means it won't be backwards-compatible with existing config files so it will force an update in the playbooks at the same time. You might want to consider not adding them to required, or only adding them to required later.
There was a problem hiding this comment.
Yeah, that's why I've made this dependant on the cdn-playbooks change. Once that's fully deployed this will be safe.
There was a problem hiding this comment.
Or I guess they'd be deployed at the same time so it's probably safe just with the playbook change merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default value of connect_timeout and read_timeout in boto is 60 seconds. Our lambdas timeout after 15 seconds. There's no reason for the inner timeouts to exceed the outer and reducing the inner timeouts may prove more helpful in debugging.