-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLOUDDST-24254 : Merge index image failing with FBC operator present … #808
Open
ashwini3326
wants to merge
3
commits into
release-engineering:master
Choose a base branch
from
ashwini3326:fix_merge_index_issue
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
CLOUDDST-24254 : Merge index image failing with FBC operator present … #808
ashwini3326
wants to merge
3
commits into
release-engineering:master
from
ashwini3326:fix_merge_index_issue
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c0ee208
to
b803aa2
Compare
lipoja
requested changes
Feb 5, 2025
083f509
to
1b1b5de
Compare
lipoja
requested changes
Feb 7, 2025
1b1b5de
to
a2c2e17
Compare
0cb3c3d
to
fcc9b6e
Compare
lipoja
reviewed
Feb 26, 2025
fcc9b6e
to
c57f6ed
Compare
lipoja
requested changes
Mar 4, 2025
c57f6ed
to
57d860b
Compare
lipoja
previously approved these changes
Mar 4, 2025
yashvardhannanavati
previously approved these changes
Mar 10, 2025
@ashwini3326 looks good! could you rebase the PR so we can merge it |
xDaile
reviewed
Mar 10, 2025
xDaile
reviewed
Mar 10, 2025
xDaile
reviewed
Mar 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comments, otherwise LGTM
57d860b
to
57f5bff
Compare
@ashwini3326 Do we need two commits here? Wouldn't one be enough? |
can't we squash the commits before merge? |
5549ce7
to
d0174b4
Compare
yashvardhannanavati
approved these changes
Mar 12, 2025
JAVGan
approved these changes
Mar 12, 2025
1be54fe
to
4aa9f73
Compare
…in source This commit fix this bug by ignoring deprecation operators which are not available in database.
4aa9f73
to
550f23a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fix this bug by ignoring deprecation operators which are not available in database.
@release-engineering/exd-guild-hello-operator