Add buildah retries on 403 #902
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the `run_cmd` regex when `buildah` runs to capture `HTTP 403` alongisde `HTTP 50X` in order to raise `ExternalServiceError`. Since the method `_build_image` already retries for `ExternalServiceError` it will automatically allow retrying the `buildah bud` command when receiving `403` instead of requiring the whole IIB request to be repeared. Refers to CLOUDDST-23254 Signed-off-by: Jonathan Gangi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the
run_cmdregex whenbuildahruns to captureHTTP 403alongisdeHTTP 50Xin order to raiseExternalServiceError.Since the method
_build_imagealready retries forExternalServiceErrorit will automatically allow retrying thebuildah budcommand when receiving403instead of requiring the whole IIB request to be repeared.Refers to CLOUDDST-23254