Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
client: allow file upload size to be sent a string
... for uploads which sizes exceed the xmlrpc.client.MAXINT limit for int values. This change should not be backwards incompatible. Old client with newer hub should work seamlessly. And new hub with older client would crash with the following traceback anyway. Fixes the following traceback: ``` $ truncate -s 2G test $ osh/client/osh-cli mock-build --tarball-build-script=test ./test Traceback (most recent call last): File "/src/osh/client/osh-cli", line 79, in <module> main() File "/src/osh/client/osh-cli", line 72, in main parser.run() File "/src/kobo/kobo/cli.py", line 296, in run cmd.run(*cmd_args, **cmd_kwargs) File "/src/osh/client/commands/cmd_diff_build.py", line 157, in run target_dir, self.parser) File "/src/osh/client/commands/shortcuts.py", line 145, in upload_file return hub.upload_file(os.path.expanduser(srpm), target_dir) File "/src/kobo/kobo/client/__init__.py", line 473, in upload_file upload_id, upload_key = self.upload.register_upload(os.path.basename(file_name), checksum, fsize, target_dir) File "/usr/lib64/python3.6/xmlrpc/client.py", line 1112, in __call__ return self.__send(self.__name, args) File "/usr/lib64/python3.6/xmlrpc/client.py", line 1446, in __request allow_none=self.__allow_none).encode(self.__encoding, 'xmlcharrefreplace') File "/usr/lib64/python3.6/xmlrpc/client.py", line 971, in dumps data = m.dumps(params) File "/usr/lib64/python3.6/xmlrpc/client.py", line 502, in dumps dump(v, write) File "/usr/lib64/python3.6/xmlrpc/client.py", line 524, in __dump f(self, value, write) File "/usr/lib64/python3.6/xmlrpc/client.py", line 540, in dump_long raise OverflowError("int exceeds XML-RPC limits") OverflowError: int exceeds XML-RPC limits ``` Resolves: #216
- Loading branch information