Merge pull request #261 from lzaoral/worker-dead-thread-deadlock

worker: fix deadlock when the `LoggingThread` is not running
release-engineering · May 2, 2024 · b3720e0 · b3720e0
2 parents d4b1c22 + 66caaab
commit b3720e0
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/kobo/worker/logger.py b/kobo/worker/logger.py
@@ -89,6 +89,11 @@ def run(self):
 
     def write(self, data):
         """Add data to the queue and set the event for sending queue content."""
+        # Discard the data if the thread is not running to prevent deadlock
+        # when the queue is full.
+        if not self.is_alive():
+            return
+
         if threading.get_ident() != self.ident:
             self._queue.put(data)
             self._event.set()