Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assignment of single_request variable #215

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

siteshwar
Copy link
Contributor

It should be assigned outside _single_request3 function. This fixes a regression introduced by 69804b3

It should be assigned outside `_single_request3` function. This fixes a
regression introduced by 69804b3
Copy link
Contributor

@lzaoral lzaoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This fixes the login issue discovered by the OpenScanHub CI!

@siteshwar
Copy link
Contributor Author

@rohanpm Latest version of kobo breaks authentication. This pull request should be merged asap and a new version of kobo should be released.

@siteshwar
Copy link
Contributor Author

LGTM! This fixes the login issue discovered by the OpenScanHub CI!

Example failure can be seen in OpenScanHub GitHub Actions CI.

@rohanpm rohanpm merged commit 2749e31 into release-engineering:master Aug 10, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants