Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hub: make Task.save() atomic #221

Merged
merged 2 commits into from
Aug 27, 2023
Merged

hub: make Task.save() atomic #221

merged 2 commits into from
Aug 27, 2023

Commits on Aug 24, 2023

  1. hub: do not call save twice in Task.save() 

    ... to ensure that the db operation is atomic.

Fixes: c5d7f8e ("Fix calculating the number of task's subtasks in new Django versions")
Related: release-engineering#217 (comment)
    @lzaoral
    lzaoral committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    ee6f357 View commit details
    Browse the repository at this point in the history

  2. hub: decorate Task.save with transaction.atomic 

    ... to ensure that the task and its parent are updated atomically.
    @lzaoral
    lzaoral committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    da941ba View commit details
    Browse the repository at this point in the history