django: allow '/' character in usernames #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdudka
approved these changes
Nov 15, 2023
rohanpm
requested changes
Nov 15, 2023
All worker usernames use the `worker/hostname` format which did not match the regular expression in the corresponding field validator. Therefore, worker user profiles could not be directly edited in the Django Admin. Resolves: openscanhub/openscanhub#185
lzaoral
force-pushed
the
allow-slash-username
branch
from
7717746
to
32ff0cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All worker usernames use the
worker/hostnameformat which did not match the regular expression in the corresponding field validator. Therefore, worker user profiles could not be directly edited in the Django Admin.Resolves: openscanhub/openscanhub#185