Add support for Django 5.0 #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.. to fix the following deprecation warning: ``` tests/test_views.py::TestAuthView::test_logout kobo/.tox/py312-django4/lib/python3.12/site-packages/django/contrib/auth/views.py:142: RemovedInDjango50Warning: Log out via GET requests is deprecated and will be removed in Django 5.0. Use POST requests for logging out. ``` Django documentation recommends to use a appropriately styled form as the replacement. Related: https://docs.djangoproject.com/en/dev/releases/4.1/#log-out-via-get
Fixes the following traceback: ``` Traceback: /opt/homebrew/Cellar/[email protected]/3.12.0/Frameworks/Python.framework/Versions/3.12/lib/python3.12/importlib/__init__.py:90: in import_module return _bootstrap._gcd_import(name[level:], package, level) tests/test_xmlrpc_auth.py:8: in <module> from kobo.hub.models import Worker kobo/hub/models.py:30: in <module> import kobo.django.fields kobo/django/fields.py:9: in <module> from django.forms.fields import CallableChoiceIterator E ImportError: cannot import name 'CallableChoiceIterator' from 'django.forms.fields' ```
... for supported Python releases. Related: https://docs.djangoproject.com/en/5.0/releases/5.0/#python-compatibility
rohanpm
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.