Add option for get_worker_tasks to also return ASSIGNED tasks #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This behavior was recently changed in [1], where this function now only returns OPEN tasks. This caused a regression in our service - which uses a custom task manager. Add an parameter to restore the old behavior. The parameter will be unused by default, so the default behavior remains unchanged. [1]: release-engineering#251
|
@lzaoral Is this change acceptable for you? |
emilyzheng
approved these changes
Jun 28, 2024
|
@querti Sorry! I have completely missed this discussion. :/ Yeah, it looks fine me. Either way, I haven't been very active in @openscanhub development for past few months and it's unlikely that it will change anytime soon. Please, tag @siteshwar or @kdudka in the future for comments regarding contributions that may affect @openscanhub. Thank you! edit: typo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This behavior was recently changed in 1, where this function now only returns OPEN tasks. This caused a regression in our service - which uses a custom task manager. Add an parameter to restore the old behavior. The parameter will be unused by default, so the default behavior remains unchanged.
Refers to CLOUDDST-23359