Skip to content

Commit

Permalink
Drop mypy from "tox -e static"
Browse files Browse the repository at this point in the history
mypy started to complain with:

    pubtools/exodus/gateway.py:8: error: Library stubs not installed for "requests.packages.urllib3.util.retry"  [import-untyped]
    pubtools/exodus/gateway.py:8: note: Hint: "python3 -m pip install types-requests"

...despite that types-requests *is* already installed. Other projects
have seen similar issues.

As we do not seem to detect any genuine issues with mypy in practice,
let's drop it from the default CI configuration to reduce the CI
maintenance cost. mypy currently remains in the test-requirements.txt
file to enable running the tool locally.
  • Loading branch information
rohanpm committed Nov 13, 2023
1 parent ff26b84 commit e01f607
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ allowlist_externals=sh

[testenv:static]
commands=
mypy --install-types --non-interactive -p pubtools -p tests
sh -c 'pylint pubtools; test $(( $? & (1|2|4|32) )) = 0'
black --check .
isort --check .
Expand Down

0 comments on commit e01f607

Please sign in to comment.