fix bounds typo and change get_buffer to reference its argument inste…

…ad of the module variable (NOAA-GFDL#1160)

Co-authored-by: rem1776 <[email protected]>

diag_manager/fms_diag_buffer.F90

@@ -50,7 +50,8 @@ module fms_diag_buffer_mod
   procedure :: flush_buffer
   procedure :: remap_buffer
   procedure :: set_buffer_id
-  ! TODO deferred routines, will require some interfaces
+  ! TODO could make these 'defered' ie. declared here but defined in each child type
+  ! holding off cause the class(*) + polymorphism in here is probably already enough to upset the gods of compilation
   !procedure(allocate_buffer), deferred :: allocate_buffer
   !procedure, deferred :: get_buffer
   !procedure, deferred :: initialize_buffer
@@ -64,7 +65,7 @@ module fms_diag_buffer_mod
 
 !> Scalar buffer type to extend fmsDiagBufferContainer_type
 type, extends(fmsDiagBuffer_class) :: buffer0d_type
-  class(*), allocatable :: buffer(:) !< "scalar" numberic buffer value
+  class(*), allocatable :: buffer(:) !< "scalar" numeric buffer value
                                      !! will only be allocated to hold 1 value
   class(*), allocatable :: counter(:) !< (x,y,z, time-of-day) used in the time averaging functions
   contains

diag_manager/fms_diag_object.F90

@@ -722,9 +722,9 @@ function get_diag_buffer(this, bufferid) &
   class(fmsDiagObject_type), intent(in) :: this
   integer, intent(in)                   :: bufferid
   class(fmsDiagBuffer_class),allocatable:: rslt
-  if( (bufferid .gt. UBOUND(this%FMS_diag_buffers, 1)) .or. (bufferid .lt. UBOUND(this%FMS_diag_buffers, 1))) &
+  if( (bufferid .gt. UBOUND(this%FMS_diag_buffers, 1)) .or. (bufferid .lt. LBOUND(this%FMS_diag_buffers, 1))) &
     call mpp_error(FATAL, 'get_diag_bufer: invalid bufferid given')
-  rslt = fms_diag_object%FMS_diag_buffers(bufferid)%diag_buffer_obj
+  rslt = this%FMS_diag_buffers(bufferid)%diag_buffer_obj
 end function
 #endif