Removing linkTarget option

[galabra]

Initial checklist

• I read the support docs
• I read the contributing guide
• I agree to follow the code of conduct
• I searched issues and couldn’t find anything (or linked relevant results below)
• If applicable, I’ve added docs and tests

Description of changes

Following the discussion in #761, I removed the redundant linkTarget prop.
This functionality can still be applied using plugins, or the components prop.

[wooorm]

Thanks for the PR!

I think this is a good idea. And I’ll be doing a major in a couple weeks. So this is 👍 in my opinion. What do you think, @remcohaszing, @ChristianMurphy?

Just jotting down for myself that I should also probably add an example to the readme to show how rehype-external-links can be used!

[remcohaszing]

Yep, I agree

[ChristianMurphy]

Seems like a good idea to me as well. 👍
It fits well with the overarching goal of better alignment of this package with the rest of the unified/remark ecosystem.

[codecov-commenter]

Codecov Report

Patch and project coverage have no change.

Comparison is base (0242d11) 100.00% compared to head (a739291) 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #762   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          754       733   -21     
=========================================
- Hits           754       733   -21     

Files Changed	Coverage Δ
lib/ast-to-react.js	100.00% <ø> (ø)
lib/react-markdown.js	100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[louh]

Documentation should really be updated to show specifically how to migrate from linkTarget to using the rehype-external-links plugin.

I had to figure this out myself. In case anyone is coming here looking for help:

Before:

<ReactMarkdown linkTarget="_blank">
  {yourContent}
</ReactMarkdown>

After:

import rehypeExternalLinks from 'rehype-external-links'

<ReactMarkdown rehypePlugins={[[rehypeExternalLinks, { target: '_blank' }]]}>
  {yourContent}
</ReactMarkdown>

Basically rehypePlugins will accept any value that is accepted by unified.use(). The double nested array is there in case you need more than one plugin.

Hope that helps someone.

[wooorm]

It’s documented https://github.com/remarkjs/react-markdown/releases/tag/9.0.0.