-
-
Notifications
You must be signed in to change notification settings - Fork 865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate the className prop #799
base: main
Are you sure you want to change the base?
Conversation
Users should wrap the `<Markdown>` component inside a `<div>` manually instead. Closes #781
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #799 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 1354 1337 -17
Branches 113 110 -3
=========================================
- Hits 1354 1337 -17 ☔ View full report in Codecov by Sentry. |
I misinterpreted the meaning of the word deprecated here originally in a late evening. I interpret deprecated as planned for change or removal with a warning. In this project deprecated means removed with an error, making deprecations semver major. |
Can you drop the changelog entry? I’ll write the changelog/migration manually when the time is there! |
Sure 👍 It just feeld a bit weird to link a non-existent header from the code. |
Ah that’s why, hmm, then I’d do a |
Since this change is breaking, this PR shouldn’t be merged until the next major anyway. I think this PR thread is plenty reminder once this gets merged. :) |
Initial checklist
Description of changes
This deprecates the
className
prop, but does not remove it yet. Users should wrap the<Markdown>
component inside a<div>
manually instead.Closes #781